Transparently replace promotion adjustments #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...whether the old system created them, or the new system created them.
If you switch to this promotion system, we're assuming that you have all your promotions migrated before you start using it. If that is the case, with this change, `order.recalculate` will transparently replace old promotion system adjustment with new promotion system adjustments.
We already have the promotion code on the join table between promotions and orders. No need to also store it on the adjustment.
This iterates through all promo adjustments and tries to get their eligibility through their source, which is really going through the terrace door rather than the front door.
davecandlescience
approved these changes
Oct 13, 2023
mamhoff
added a commit
that referenced
this pull request
Jul 1, 2024
Transparently replace promotion adjustments
mamhoff
added a commit
that referenced
this pull request
Oct 25, 2024
Transparently replace promotion adjustments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to support the migration of existing stores. After having migrated the promotion configuration, you can flip the switch, and old promotion system adjustments will be replaced by new promotion system adjustments.