This repository was archived by the owner on Feb 19, 2025. It is now read-only.
Promotion Actions: Implement "edit" action #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when changing the promotion calculator type for an action, we would end up with an unrescued 500 error. This implements editing an action.
|
Nit: when changing the calculator type it is saved immediately, which is different from all of the other fields on the page. |
|
Yeah, true. However, changing that behavior would require an extensive overhaul of the entire page, and this page is really only for admins. I think it's okay. |
mamhoff
added a commit
that referenced
this pull request
Jul 1, 2024
Promotion Actions: Implement "edit" action
mamhoff
added a commit
that referenced
this pull request
Oct 25, 2024
Promotion Actions: Implement "edit" action
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when changing the promotion calculator type for an action, we would end up with an unrescued 500 error. This implements editing an action.