This repository was archived by the owner on Feb 19, 2025. It is now read-only.
Migrate promotion categories and association #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Promotion categories are infrequently used but still need to be included in the migration. They are an optional association and there are no uniqueness checks on the name, which is why there is a find_by instead of a more solid connection to the old category.
davecandlescience
force-pushed
the
migrate-promotion-categories
branch
from
becad9b to
bfd6e94
Compare
mamhoff
approved these changes
Oct 17, 2023
mamhoff
pushed a commit
that referenced
this pull request
Jul 1, 2024
Migrate promotion categories and association
mamhoff
pushed a commit
that referenced
this pull request
Oct 25, 2024
Migrate promotion categories and association
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Promotion categories are infrequently used but still need to be included in the migration. They are an optional association and there are no uniqueness checks on the name, which is why there is a find_by instead of a more solid connection to the old category.
Fixes issue 37