Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import eligiblity error messages from Solidus #48

Merged
merged 1 commit into from
Oct 21, 2023

Conversation

mamhoff
Copy link
Contributor

@mamhoff mamhoff commented Oct 20, 2023

We want to have all the relevant I18n content for promotions in this gem, under our namespace. This commit accomplishes that.

missing_taxon: You need to add a product from all applicable categories before applying this coupon code.
no_matching_taxons: You need to add a product from an applicable category before applying this coupon code.
solidus_friendly_promotions/rules/user:
no_user_specified: You need to login before applying this coupon code.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: pretty

Copy link
Collaborator

@davecandlescience davecandlescience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one tiny nit

We want to have all the relevant I18n content for promotions in this
gem, under our namespace. This commit accomplishes that.
@mamhoff mamhoff force-pushed the import-eligibility-errors branch from d0046e5 to 2310e6b Compare October 20, 2023 14:21
@mamhoff mamhoff merged commit fc47a05 into main Oct 21, 2023
mamhoff added a commit that referenced this pull request Jul 1, 2024
Import eligiblity error messages from Solidus
mamhoff added a commit that referenced this pull request Oct 25, 2024
Import eligiblity error messages from Solidus
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants