Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: SolidusFriendlyPromotions, not Shipping #49

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Fix: SolidusFriendlyPromotions, not Shipping #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ In Solidus Core, Promotion adjustments get recalculated twice on every change to

The design decision here is to make the code path easier to follow, and consequently to make it more performant ("Make it easy, then make it fast").

`SolidusFriendlyShipping::Promotion` objects have rules and actions, just like `Spree::Promotion`. However, both rules and actions work slightly differently.
`SolidusFriendlyPromotions::Promotion` objects have rules and actions, just like `Spree::Promotion`. However, both rules and actions work slightly differently.

### Promotion lanes

Expand Down
2 changes: 1 addition & 1 deletion app/views/solidus_friendly_promotions/admin/promotion_rules/rules/_shipping_method.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<%= promotion_rule.class.human_attribute_name(:description) %>
</p>
<div class="form-group">
<%= label_tag "#{param_prefix}_preferred_shipping_method_ids", SolidusFriendlyShipping::Rules::ShippingMethod.human_attribute_name(:preferred_shipping_method_ids) %>
<%= label_tag "#{param_prefix}_preferred_shipping_method_ids", SolidusFriendlyPromotions::Rules::ShippingMethod.human_attribute_name(:preferred_shipping_method_ids) %>
<%= select_tag "#{param_prefix}[preferred_shipping_method_ids]",
options_from_collection_for_select(
Spree::ShippingMethod.all, :id, :name, promotion_rule.preferred_shipping_method_ids
Expand Down