Fix shipping rate discount factory #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
4
to
13
| factory :friendly_shipping_rate_discount, class: "SolidusFriendlyPromotions::ShippingRateDiscount" do | ||
| amount { BigDecimal("-4.00") } | ||
| shipping_rate | ||
| promotion_action { SolidusFriendlyPromotions::Actions::AdjustShipment.new } | ||
| promotion_action do | ||
| promotion = create(:friendly_promotion) | ||
| hundred_percent = SolidusFriendlyPromotions::Calculators::Percent.new(preferred_percent: 100) | ||
| SolidusFriendlyPromotions::Actions::AdjustShipment.create!(promotion: promotion, calculator: hundred_percent) | ||
| end | ||
| label { "10% off" } | ||
| end |
There was a problem hiding this comment.
Nit: the amount, label, and calculator percentage do not match which leads to confusion
There was a problem hiding this comment.
Mostly... line 9 var name is hundred_percent still
mamhoff
force-pushed
the
fix-shipping-rate-discount-factory
branch
from
ec861bf to
af8920b
Compare
This factory would violate a not-null constraint.
mamhoff
force-pushed
the
fix-shipping-rate-discount-factory
branch
from
af8920b to
e5530c0
Compare
mamhoff
added a commit
that referenced
this pull request
Jul 1, 2024
…actory Fix shipping rate discount factory
mamhoff
added a commit
that referenced
this pull request
Oct 25, 2024
…actory Fix shipping rate discount factory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This factory would violate a not-null constraint.