Add "Lane" enum to Promotion #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to implement stacked promotions, we need some way for the user to specify the order in which promotions run. It's really hard to imagine a UI where all promotions are sorted, so we're opting here for a coarse ordering via promotion "lanes". We imagine three lanes, "pre", "post" and "default", ordered via their enum integer. The system should first evaluate "pre" promotions, then it should evaluate "default" promotions, and then it should evaluate "post" promotions.
Every promotion now belongs to a lane, and users can configure that lane on the promotions form.
We need the lanes to be sorted by enum integer value, and we don't want that to rely on the enum declaration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the "lane" concept in the simplest way I can imagine: By just adding an enum with sortable values, we can identify the order in which stacked promotions should be applied. We do not need an additional ActiveRecord model that is sortable, as we don't want to burden administrators with creating and maintaining the lanes, and three lanes should be enough.