This repository was archived by the owner on Feb 19, 2025. It is now read-only.
Never create adjustments with a zero amount #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The specs here are a bit contrived, as it's unlikely for a calculator to have a zero percentage. However, the scenario is quite real: In shops that don't select a shipping rate automatically in the delivery step of checkout, the shipment's cost will be zero until the customer has selected a shipping rate. At this point the promotion system will happily add discounts with no amount.
Rather than selecting senseless discounts out in the order discounter, we can already tell the action to never create the discount in the first place.
mamhoff
force-pushed
the
never-create-zero-adjustments
branch
from
1288d14 to
e4c1a62
Compare
davecandlescience
approved these changes
Nov 2, 2023
mamhoff
added a commit
that referenced
this pull request
Jul 1, 2024
Never create adjustments with a zero amount
mamhoff
added a commit
that referenced
this pull request
Oct 25, 2024
Never create adjustments with a zero amount
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The specs here are a bit contrived, as it's unlikely for a calculator to have a zero percentage. However, the scenario is quite real: In shops that don't select a shipping rate automatically in the delivery step of checkout, the shipment's cost will be zero until the customer has selected a shipping rate. At this point the promotion system will happily add discounts with no amount.