Refactor to FriendlyPromotion::FriendlyPromotionAdjuster #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamhoff
force-pushed
the
refactor-discounter-api
branch
from
242649d to
deb1b42
Compare
davecandlescience
approved these changes
Nov 6, 2023
app/models/solidus_friendly_promotions/promotion_handler/coupon.rb
Outdated
Show resolved
Hide resolved
This changes the API of the main class we're working with from `SolidusFriendlyPromotions::OrderDiscounter` to `SolidusFriendlyPromotions::FriendlyPromotionsAdjuster`. This class now simply calls the three other (otherwise somewhat confusingly named) service objects: - `LoadPromotions` - `DiscountOrder` - `PersistDiscountedOrder` This makes the code easier to read in my opinion, and simplifies the API for promotion handlers significantly.
When we test whether a promotion is eligible, what we do is we perform a dry run of the promotion adjuster. This change reflects that context in the naming of our arguments.
This is to aid readability.
This class suffered of unnecessary variables, and can also live with the service classes for the FriendlyPromotionAdjuster. It also could use a spec.
mamhoff
force-pushed
the
refactor-discounter-api
branch
from
deb1b42 to
4403912
Compare
These are modules, and Rails offers a place for modules.
mamhoff
added a commit
that referenced
this pull request
Jul 1, 2024
Refactor to FriendlyPromotion::FriendlyPromotionAdjuster
mamhoff
added a commit
that referenced
this pull request
Oct 25, 2024
Refactor to FriendlyPromotion::FriendlyPromotionAdjuster
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the API of the main class we're working with from
SolidusFriendlyPromotions::OrderDiscountertoSolidusFriendlyPromotions::FriendlyPromotionsAdjuster. This class now simply calls the three other (otherwise somewhat confusingly named) service objects:LoadPromotionsDiscountOrderPersistDiscountedOrderThis makes the code easier to read in my opinion, and simplifies the API for promotion handlers significantly.