Use new NestedClassSet for configuring calculators #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamhoff
force-pushed
the
refactor-calculator-availability
branch
from
d28e888 to
dbd54fb
Compare
We have several actions, and several calculators. Not all calculators work for all actions (e.g. the DistributedAmountCalculator really only works for the AdjustLineItem action, and the `Tiered` ones don't work for `AdjustLineItemQuantityGroups`. Rather than creating a new configuration option for each calculator, let's use something like a Hash here.
mamhoff
force-pushed
the
refactor-calculator-availability
branch
from
dbd54fb to
1d2c4b6
Compare
mamhoff
added a commit
that referenced
this pull request
Jul 1, 2024
…lity Use new NestedClassSet for configuring calculators
mamhoff
added a commit
that referenced
this pull request
Oct 25, 2024
…lity Use new NestedClassSet for configuring calculators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have several actions, and several calculators. Not all calculators work for all actions (e.g. the DistributedAmountCalculator really only works for the AdjustLineItem action, and the
Tieredones don't work forAdjustLineItemQuantityGroups. Rather than creating a new configuration option for each calculator, let's use something like a Hash here.