Add configuration option: recalculate_complete_orders
#97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
approved these changes
Jan 16, 2024
|
@mamhoff Rubocop wants your attention |
This gem allows recalculating complete orders until they are shipped, because Solidus allows changing an order's contents until the order is shipped. This change adds a configuration option that disables the recalculation of orders after they are completed. Some shops make changes to existing promotions, and expect that this does not change complete, but unshipped orders.
mamhoff
force-pushed
the
optional-recalculation-after-complete
branch
from
27daeb9 to
e31f1b3
Compare
mamhoff
added a commit
that referenced
this pull request
Jul 1, 2024
…-complete Add configuration option: `recalculate_complete_orders`
mamhoff
added a commit
that referenced
this pull request
Oct 25, 2024
…-complete Add configuration option: `recalculate_complete_orders`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gem allows recalculating complete orders until they are shipped, because Solidus allows changing an order's contents until the order is shipped.
This change adds a configuration option that disables the recalculation of orders after they are completed. Some shops make changes to existing promotions, and expect that this does not change complete, but unshipped orders.