Skip to content
This repository has been archived by the owner on Feb 24, 2018. It is now read-only.

#29 - Added non-prefixed version of flex-flow for non-Chrome browsers #30

Merged
merged 1 commit into from
Jan 6, 2016

Conversation

awestmoreland
Copy link
Contributor

I was unable to test locally as react isn't working for me, but I see the markup fine on production. Could do with someone verifying change, or push and be damned ;)

…it. I was unable to test locally as react isn't working for me, but I see the markup fine on production.
@awestmoreland awestmoreland changed the title #29 - Added non-prefixed version of flex-flow for Firefox #29 - Added non-prefixed version of flex-flow for non-Chrome browsers Jan 6, 2016
@jacebrowning
Copy link
Contributor

I'll test it...

@jacebrowning
Copy link
Contributor

Right now I'm seeing GET https://api.github.com/orgs/friendlycode/repos 403 (Forbidden) in my console.

@awestmoreland
Copy link
Contributor Author

Hmm, I only changed one line of CSS, so I'm pretty sure that wouldn't affect it, but maybe @Crevax could weigh in too.

I don't see that error, but I also don't see the projects locally. I do see the projects on production, but @jacebrowning was having intermittent issues seeing them there yesterday. Sounds like an issue at Github?

@jacebrowning
Copy link
Contributor

https://api.github.com/orgs/friendlycode/repos says it's being rate limited:

{
  "message": "API rate limit exceeded for 152.160.140.86. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)",
  "documentation_url": "https://developer.github.com/v3/#rate-limiting"
}

@awestmoreland
Copy link
Contributor Author

Ah, good catch! Maybe we need to look into caching the projects daily (or even weekly) as part of #12.

@Crevax
Copy link
Member

Crevax commented Jan 6, 2016

I'm surprised we're exceeding the 60/hr limit. While authenticating would increase our limit to 5000/hr, caching the results would be a good to do as well.

@awestmoreland
Copy link
Contributor Author

Want me to add a bug/feature request, or is this still part of #12? Either way, we should probably document somewhere other than here :)

@jacebrowning
Copy link
Contributor

Submit another issue.

👍 This looks good to merge!

@awestmoreland
Copy link
Contributor Author

👍

awestmoreland added a commit that referenced this pull request Jan 6, 2016
#29 - Added non-prefixed version of flex-flow for non-Chrome browsers
@awestmoreland awestmoreland merged commit ba239fb into master Jan 6, 2016
@awestmoreland awestmoreland deleted the fix-flex-box-wrapping branch January 6, 2016 18:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants