Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support URI scheme to create connection #138

Merged
merged 1 commit into from
Aug 22, 2021

Conversation

SimonFrings
Copy link
Contributor

With these changes it's possible to pass an URI scheme to your createconnection().
If no scheme is given it defaults to mysql://
If you pass an invalid URI scheme (anything other than mysql://) it will be rejected with an InvalidArgumentException

@clue clue added this to the v0.5.6 milestone Aug 17, 2021
Copy link
Contributor

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonFrings Thanks for looking into this, changes LGTM! :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants