Add warningCount to QueryResult #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legionth
changed the title
clue
reviewed
Oct 11, 2018
There was a problem hiding this comment.
@legionth Thank you for filing this PR! I agree that it makes sense to add this to the QueryResult.
I'm a bit unsure about the naming, what do you think about warningCount instead? This way, it would mimic both PHP's ext-mysqli as well as node-mysql.
|
Makes perfectly sense 👍 Just wanted to be align with the naming of |
clue
approved these changes
Oct 11, 2018
clue
changed the title
jsor
approved these changes
Oct 11, 2018
WyriHaximus
approved these changes
Oct 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A count of warnings is currently added via
Io\Parser::onSuccess(). This value is dynamically added as attribute to the instance ofQueryCommand.This PR will add this value like
affected_rowsto theQueryCommandandQueryResultclass and adds its actual value (if given) to the instance of these classes.