Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Validate box.json.dist before compiling Phar #237

Merged
merged 2 commits into from
Apr 28, 2022
Merged

Enhancement: Validate box.json.dist before compiling Phar #237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6bdd95c
Enhancement: Validate box.json.dist
localheinz Apr 28, 2022
0e2d629
Fix: Remove settings identical to defaults
localheinz Apr 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/integrate.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,9 @@ jobs:
- name: "Install dependencies with composer"
run: "composer install --ansi --no-progress"

- name: "Validate box.json.dist with humbug/box"
run: ".phive/box validate"

- name: "Compile twigcs.phar with humbug/box"
run: ".phive/box compile"

Expand Down
1 change: 1 addition & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ help: ## Displays this list of targets with descriptions

.PHONY: phar
phar: vendor ## Compiles a phar with humbug/box
.phive/box validate
.phive/box build
php twigcs.phar --version

Expand Down
4 changes: 1 addition & 3 deletions box.json.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
{
"stub": true,
"main": "bin/twigcs",
"directories": ["src", "vendor"],
"git-version": "__VERSION__",
"output": "twigcs.phar",
"chmod": "0700"
}
}