Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gitlab reporter #243

Merged
merged 12 commits into from
May 13, 2022
Merged

Conversation

frankdekker
Copy link
Contributor

@frankdekker frankdekker commented May 13, 2022

Added reporter that is supported by gitlab ci.

  • Added new Reporter/GitlabReporter
  • Added GitlabReporter to Container.php
  • Added unit test for GitlabReporter

@codecov-commenter
Copy link

codecov-commenter commented May 13, 2022

Codecov Report

Merging #243 (df60655) into main (918c274) will increase coverage by 0.16%.
The diff coverage is 95.65%.

@@             Coverage Diff              @@
##               main     #243      +/-   ##
============================================
+ Coverage     78.57%   78.73%   +0.16%     
- Complexity      743      748       +5     
============================================
  Files            54       55       +1     
  Lines          2385     2408      +23     
============================================
+ Hits           1874     1896      +22     
- Misses          511      512       +1     
Impacted Files Coverage Δ
src/Container.php 73.91% <50.00%> (-2.28%) ⬇️
src/Reporter/GitLabReporter.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 918c274...df60655. Read the comment docs.

README.md Show resolved Hide resolved
Copy link
Collaborator

@localheinz localheinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than perhaps adding a reference to the underlying GitLab documentation that helps document the expected output format, this looks good to me!

👍

@localheinz localheinz merged commit 4175e94 into friendsoftwig:main May 13, 2022
@localheinz
Copy link
Collaborator

Thank you, @Ciloe and @frankdekker!

@frankdekker
Copy link
Contributor Author

@localheinz
Thanks for the fast review. Any chance these changes can be added to a release so a package is available?

@localheinz
Copy link
Collaborator

@OwlyCode

Can you prepare a release - or shall I do it?

@localheinz
Copy link
Collaborator

@OwlyCode

I would not mind creating a release myself, but I would need to sign it with my own keys - do you have any objections?

@frankdekker frankdekker deleted the Add-gitlab-reporter branch November 27, 2022 13:34
@broeredaan
Copy link

Hi there would also like to make use of this. Any chance we can get a release for this? @localheinz @OwlyCode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants