Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Update friendsofphp/php-cs-fixer #306

Merged
merged 4 commits into from
Nov 29, 2023

Conversation

localheinz
Copy link
Collaborator

@localheinz localheinz commented Nov 29, 2023

This pull request

  • updates friendsofphp/php-cs-fixer
  • runs make coding-standards
  • configures the braces_position instead of the deprecated braces fixer
  • runs make static-code-analysis-baseline

πŸ’β€β™‚οΈ For reference, see PHP-CS-Fixer/PHP-CS-Fixer@v3.16.0...v3.40.0.

@localheinz localheinz self-assigned this Nov 29, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (1967123) 79.83% compared to head (7c424e6) 79.83%.

Files Patch % Lines
src/TwigPort/Token.php 0.00% 3 Missing ⚠️
src/Config/Config.php 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #306   +/-   ##
=========================================
  Coverage     79.83%   79.83%           
  Complexity      749      749           
=========================================
  Files            55       55           
  Lines          2603     2603           
=========================================
  Hits           2078     2078           
  Misses          525      525           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@localheinz localheinz marked this pull request as ready for review November 29, 2023 16:47
@localheinz localheinz merged commit 83b593c into friendsoftwig:main Nov 29, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants