Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PHP 8.4 #332

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Conversation

cedric-anne
Copy link
Contributor

Implicitly nullable parameter declarations are deprecated in PHP 8.4. The proposed change is safe and is not considered by PHP as a signature change, see https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated

@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.83%. Comparing base (2d8bde1) to head (a8a61ba).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
src/Rule/AbstractRule.php 0.00% 1 Missing ⚠️
src/TwigPort/TokenStream.php 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #332   +/-   ##
=========================================
  Coverage     79.83%   79.83%           
  Complexity      749      749           
=========================================
  Files            55       55           
  Lines          2603     2603           
=========================================
  Hits           2078     2078           
  Misses          525      525           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cedric-anne
Copy link
Contributor Author

Hi,

Is this possible to get this merged and released ? Not a big deal, but it pollutes our CI results.

@localheinz localheinz self-assigned this Nov 27, 2024
@localheinz localheinz merged commit b98f277 into friendsoftwig:main Nov 27, 2024
10 checks passed
@localheinz
Copy link
Collaborator

Thank you, @cedric-anne!

@cedric-anne cedric-anne deleted the feature/php-8.4 branch November 27, 2024 21:42
@localheinz
Copy link
Collaborator

Released as friendsoftwig/twigcs:6.5.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants