Update database semantic conventions #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should resolve #7 |
frigus02
reviewed
Aug 6, 2020
There was a problem hiding this comment.
This looks good. Thanks for taking care of this.
The two properties are also defined near the top of the file in a HashSet. The reason is that I didn't want to include them in the custom properties, since the value is already used elsewhere:
opentelemetry-application-insights/src/lib.rs
Lines 119 to 120 in a3b0f6f
I'm not sure if this is a good idea anymore. It might be better to send all attributes as custom properties either way.
But in any case, would you mind changing those to the new names as well for now?
Release v0.6.0 of the opentelemetry spec included some changes to the database semantic conventions, among them being changes to some of the fields used to convert to Azure Dependency Targets etc. open-telemetry/opentelemetry-specification#575 This commit updates the exporter to handle the new names for these fields, however as the new equivalent to `db.instance` is `db.name`, which can change when the database is changed inside a connection.
johnchildren
force-pushed
the
update-database-semantic-conventions
branch
from
a3b0f6f
to
072b866
Compare
|
Ah sorry, don't know how I missed that, I did try to do a search through the codebase! Anyway should be updated now. |
frigus02
approved these changes
Aug 7, 2020
|
Perfect. Thanks again 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release v0.6.0 of the opentelemetry spec included some changes to the
database semantic conventions, among them being changes to some of the
fields used to convert to Azure Dependency Targets etc.
open-telemetry/opentelemetry-specification#575
This commit updates the exporter to handle the new names for these
fields, however as the new equivalent to
db.instanceisdb.name,which can change when the database is changed inside a connection.