Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What was changed in 2.0? #105

Open
acflint opened this issue Mar 25, 2024 · 3 comments
Open

What was changed in 2.0? #105

acflint opened this issue Mar 25, 2024 · 3 comments

Comments

@acflint
Copy link

acflint commented Mar 25, 2024

Hi folks, excited to see an update published! Do you have a change log of what's included in 2.0? Any breaking changes? Thanks so much.

@julik
Copy link
Contributor

julik commented Apr 17, 2024

Hey @acflint since I was behind most changes I could give you a short summary:

  • The zip_tricks dependency (older and Hippocratic-licensed) has been replaced with zip_kit (modernized zip_tricks under standard MIT license)
  • Consequently, the minimum required Ruby version is now 2.6 as this is what zip_kit requires
  • zipline uses write_file and picks the deflate/stored mode for you automatically
  • The HTTP streaming parts are now serviced by zip_kit, not zipline itself - as this potentially allows better compat with things such as ActionController::Live and different webservers
  • If your webserver is likely to buffer your response there will be a message in the Rails log
  • If an error occurs during streaming, likewise: an error will be printed to the Rails log explaining what went wrong

In the works: there is some groundwork for continuing if a file fails to fetch from remote storage (to proceed to the next file). It looks like it would be appropriate to add a changelog, I will tackle that after #104 is done

@acflint
Copy link
Author

acflint commented Apr 17, 2024

Thanks @julik! Those sound like exciting changes. Does the API or usage change at all? Or should this be a simple upgrade?

@julik
Copy link
Contributor

julik commented Apr 17, 2024

Should be a simple upgrade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants