Do you have any plans to support vue3? #137

nsano-rururu · 2021-11-28T16:50:26Z

No description provided.

fritx · 2021-12-17T08:25:56Z

@nsano-rururu yes, I did, any work or help is appreciated!

PaulSaveur · 2022-05-20T09:53:38Z

Hi, some news about vue 3 compatibility ??

Qiao0124 · 2022-07-12T02:52:43Z

@fritx Is there a version that supports VUE3 or is it under development？

nsano-rururu · 2022-07-23T05:23:41Z

@XIwen-chuan

It seems that vue3 support hasn't done anything yet.
I think the following actions are necessary.

Migrating From JavaScript to TypeScript
- Add ESLint
Migrating From Webpack to Vite
Vue 3 Support
- element-ui to element-plus
- vuetify 2.x to 3.x

Qiao0124 · 2022-08-01T13:34:31Z

@nsano-rururu thank you. this project is unique and useful. looking forward to supporting vue3

fritx · 2022-08-03T10:05:59Z

@nsano-rururu @XIwen-chuan now I'm trying with this guide:

Vue 3 Migration Build: safely upgrade your app to Vue 3 (Pt. 1)
https://www.vuemastery.com/blog/vue-3-migration-build/

fritx · 2022-08-03T15:02:49Z

@nsano-rururu yes, agreed, but eslint is now off-topic right now.
Let's deal with vue3 first

I've just pushed the wip branch above
https://github.com/fritx/vue-at/commits/wip-vue3

...where I've worked out several errors except this one (failing to insert styled tag into editor):

[Vue warn]: Missing ref owner context. ref cannot be used on hoisted vnodes.
A vnode with ref must be created inside the render function.

Official guide I was following:
https://v3-migration.vuejs.org/migration-build.html#preparations

nsano-rururu · 2022-08-03T15:20:24Z

@fritx

It's not irrelevant as eslint will tell you where you need vue3 compatibility with warnings and errors.

I would appreciate it if you could consider it as information that there is such a thing. There is no compulsion to adopt or not.

…nt warnings bug regression commit: 725d7a1#diff-11090ff0a927c36112fd70be4c32aa3841151637c37309ea0f8c429f00c9ed61L335 #137

…sted vnodes. -- #137 seems could not use `:ref="xxx"` not more here

…nt warnings -- #137 bug regression commit: 725d7a1#diff-11090ff0a927c36112fd70be4c32aa3841151637c37309ea0f8c429f00c9ed61L335

fritx · 2022-08-08T13:25:03Z

eslint is done! And now it seems to work. Checkout it out, pls wip-vue3

Any interest in contributing to PR that switches to vite ? @nsano-rururu @XIwen-chuan @PaulSaveur

…sted vnodes. -- #137 seems could not use `:ref="xxx"` not more here

…nt warnings -- #137 bug regression commit: 725d7a1#diff-11090ff0a927c36112fd70be4c32aa3841151637c37309ea0f8c429f00c9ed61L335

Qiao0124 · 2022-08-08T13:49:22Z

Yes,my pleasure

…r eslint warnings -- #137 bug regression commit: 725d7a1#diff-11090ff0a927c36112fd70be4c32aa3841151637c37309ea0f8c429f00c9ed61L335

fritx · 2022-08-09T12:22:58Z

nsano-rururu · 2022-08-09T13:28:29Z

@fritx @XIwen-chuan

I've tried it locally so far. I don't know how to fix existing vue-cli commands to vite commands.

.eslintrc.js

add

    eqeqeq: 'off',
    'no-tabs': 'off',

index.html

add 「<script type="module" src="/src/main.js"></script>」

<!DOCTYPE html>
<html lang="en">
  <head>
    <meta charset="utf-8">
    <meta name="viewport" content="width=device-width">
    <title>vue-at</title>
  </head>
  <body>
    <div id="app"></div>
    <script src="dist/demo.js"></script>
    <script type="module" src="/src/main.js"></script>
</body>
</html>

[new]vite.config.js

import { defineConfig } from 'vite'
import path from 'path'
import envCompatible from 'vite-plugin-env-compatible'
import { createHtmlPlugin } from 'vite-plugin-html'
import { viteCommonjs } from '@originjs/vite-plugin-commonjs'
import vue from '@vitejs/plugin-vue'

// https://vitejs.dev/config/
export default defineConfig({
  resolve: {
    alias: [
      {
        find: /^~/,
        replacement: ''
      },
      {
        find: '@',
        replacement: path.resolve(__dirname, 'src')
      }
    ],
    extensions: [
      '.mjs',
      '.js',
      '.ts',
      '.jsx',
      '.tsx',
      '.json',
      '.vue'
    ]
  },
  plugins: [
    vue(),
    viteCommonjs(),
    envCompatible(),
    createHtmlPlugin({
      inject: {
        data: {
          title: 'vue-at'
        }
      }
    })
  ],
  css: {
    preprocessorOptions: {
      sass: {},
      scss: {}
    }
  },
  build: {}
})

package.json

add

"prepublish": "npm run build",
"serve-vite": "vite",
"build-vite": "vite build",
"preview-vite": "vite preview"

"@vitejs/plugin-vue": "^3.0.1",
"@originjs/vite-plugin-commonjs": "^1.0.1",
"vite": "^3.0.1",
"vite-plugin-env-compatible": "^1.1.1",
"vite-plugin-html": "3.2.0",

{
  "name": "vue-at",
  "description": "At.js for Vue",
  "version": "3.0.0-alpha.0",
  "author": "Fritz Lin <uxfritz@163.com>",
  "repository": "https://github.com/fritx/vue-at",
  "scripts": {
    "lint:fix": "vue-cli-service lint",
    "lint": "vue-cli-service lint --no-fix",
    "dev:dist": "vue-cli-service serve --skip-plugins eslint",
    "dev": "vue-cli-service serve",
    "build:at": "vue-cli-service build ./src/At.vue --target lib --name vue-at",
    "build:at-ta": "vue-cli-service build ./src/AtTextarea.vue --target lib --name vue-at-textarea",
    "build": "rimraf dist && run-p build:at build:at-ta && rimraf dist/demo.html",
    "prepublish": "npm run build",
    "serve-vite": "vite",
    "build-vite": "vite build",
    "preview-vite": "vite preview"
  },
  "main": "dist/vue-at.common.js",
  "engines": {
    "node": ">= 14.x"
  },
  "dependencies": {
    "@vitejs/plugin-vue": "^3.0.1",
    "textarea-caret": "^3.1.0"
  },
  "peerDependencies": {
    "vue": "3.x"
  },
  "devDependencies": {
    "@babel/core": "^7.18.9",
    "@originjs/vite-plugin-commonjs": "^1.0.1",
    "@vue/cli-plugin-eslint": "^5.0.8",
    "@vue/cli-service": "^5.0.8",
    "@vue/compat": "^3.1.0",
    "@vue/compiler-sfc": "^3.1.0",
    "@vue/eslint-config-standard": "^8.0.1",
    "element-plus": "^2.2.12",
    "eslint": "^8.21.0",
    "eslint-plugin-vue": "^9.3.0",
    "npm-run-all": "^4.1.5",
    "rimraf": "^3.0.2",
    "sass": "^1.53.0",
    "sass-loader": "^13.0.2",
    "vite": "^3.0.1",
    "vite-plugin-env-compatible": "^1.1.1",
    "vite-plugin-html": "3.2.0",
    "vue": "^3.1.0",
    "vue-loader": "^16.0.0",
    "webpack": "^5.73.0"
  }
}

#137 vitejs/vite#4345 vitejs/vite#9086

fritx · 2022-08-09T13:47:25Z

@nsano-rururu cool, I'll take a look later

Also see #137 (comment)
Check my branch out, it seems to work now: wip-vite

nsano-rururu · 2022-08-09T14:21:23Z

@fritx

There is no problem other than eslint errors.

[CORP\sano@a-19f9vs8e9ite4 vue-at]$ npm run lint

> vue-at@3.0.0-alpha.0 lint
> eslint --ext .js,.vue --ignore-path .gitignore src


/home/sano/dkwork3/e/vue-at/src/util.js
   8:22  error  Expected '===' and instead saw '=='  eqeqeq
  14:27  error  Unexpected tab character             no-tabs
  15:21  error  Unexpected tab character             no-tabs
  19:20  error  Expected '===' and instead saw '=='  eqeqeq
  25:26  error  Expected '!==' and instead saw '!='  eqeqeq

✖ 5 problems (5 errors, 0 warnings)

fritx · 2022-08-11T05:22:12Z

@nsano-rururu ah that's fixed. and 3.0.0-alpha.0 was already released.

npm i -S vue-at@3.0.0-alpha.2
# or
npm i -S vue-at@next

demo: https://github.com/we-demo/vue-at-vite-app

progress: #137 (comment)

#137 vitejs/vite#4345 vitejs/vite#9086

vuetifyjs/vuetify#4068 (comment) vuejs/core#4344 (comment)

fritx · 2022-09-04T05:31:40Z

@nsano-rururu i'm not sure how to still support babel es2015-safe build via vite, any idea?

#137 (comment)

nsano-rururu · 2022-09-04T06:11:59Z

Sounds like you need to look into babel-preset-env options.
https://babeljs.io/docs/en/env/

nsano-rururu · 2022-09-04T06:20:11Z

babel-preset-env seems to transpile everything to ES5 notation if no options are specified.

fritx · 2022-09-04T09:37:53Z

@nsano-rururu but i could not manage to make babel work well with vite (library mode) 😢
vitejs/vite#1639

nsano-rururu · 2022-09-04T10:27:33Z

@fritx
Isn't it better not to move to vite yet?.
I think it's better to migrate to vite after a solution is found.

nsano-rururu · 2022-11-04T16:47:20Z

@fritx
It seems that the stable version of vuetify3 compatible with vue3 has been released
https://github.com/vuetifyjs/vuetify/releases/tag/v3.0.0

junaidshad · 2023-03-17T07:10:06Z

What is the update on this?
we're receiving webpack issues on "vue-at@next" branch (upgrading while migration: using compat build)

fritx · 2023-03-20T04:33:58Z

@junaidshad try vue-at@latest first. Is there a minimal demo?

fritx · 2023-03-20T04:58:48Z

@junaidshad also try the umd way, it can be a fallback solution
https://github.com/fritx/vue-at/blob/vue3/test_umd.html
https://github.com/fritx/vue-at/tree/vue3#umd-also-supported

junaidshad · 2023-03-21T07:08:33Z

@fritx
Yes, It worked the umd way.

fritx self-assigned this Aug 3, 2022

fritx added important in-progress labels Aug 3, 2022

This comment was marked as off-topic.

Sign in to view

fritx added a commit that referenced this issue Aug 3, 2022

wip: vue3 support -- #137

8fe746d

fritx added a commit that referenced this issue Aug 3, 2022

wip: vue3 support -- #137

43382bc

fritx added a commit that referenced this issue Aug 8, 2022

fix bug: At.vue insertHtml 'suffix' is not defined !! also other esli…

739a63c

…nt warnings bug regression commit: 725d7a1#diff-11090ff0a927c36112fd70be4c32aa3841151637c37309ea0f8c429f00c9ed61L335 #137

fritx added a commit that referenced this issue Aug 8, 2022

fix: [Vue warn]: Missing ref owner context. ref cannot be used on hoi…

2328dea

…sted vnodes. -- #137 seems could not use `:ref="xxx"` not more here

fritx added a commit that referenced this issue Aug 8, 2022

fix bug: At.vue insertHtml 'suffix' is not defined !! also other esli…

4e46e5a

…nt warnings -- #137 bug regression commit: 725d7a1#diff-11090ff0a927c36112fd70be4c32aa3841151637c37309ea0f8c429f00c9ed61L335

fritx added a commit that referenced this issue Aug 8, 2022

wip: vue3 support & switch to @vue/cli-service -- #137

bbe71ae

fritx added a commit that referenced this issue Aug 8, 2022

fix: [Vue warn]: Missing ref owner context. ref cannot be used on hoi…

488ced3

…sted vnodes. -- #137 seems could not use `:ref="xxx"` not more here

fritx added a commit that referenced this issue Aug 8, 2022

fix bug: At.vue insertHtml 'suffix' is not defined !! also other esli…

ddbbaea

…nt warnings -- #137 bug regression commit: 725d7a1#diff-11090ff0a927c36112fd70be4c32aa3841151637c37309ea0f8c429f00c9ed61L335

fritx pinned this issue Aug 8, 2022

fritx added a commit that referenced this issue Aug 9, 2022

[gcp] fix bug: At.vue insertHtml 'suffix' is not defined !! also othe…

021b002

…r eslint warnings -- #137 bug regression commit: 725d7a1#diff-11090ff0a927c36112fd70be4c32aa3841151637c37309ea0f8c429f00c9ed61L335

fritx added a commit that referenced this issue Aug 9, 2022

wip: switched to vite. todo: vite should support css.extract=false

37ca4e0

#137 vitejs/vite#4345 vitejs/vite#9086

fritx added a commit that referenced this issue Aug 11, 2022

wip: switched to vite. todo: vite should support css.extract=false

1212f1d

#137 vitejs/vite#4345 vitejs/vite#9086

fritx added vue3 vite labels Sep 2, 2022

fritx added a commit that referenced this issue Sep 2, 2022

switching to vite !! + umd support -- #137

dce37bc

vuetifyjs/vuetify#4068 (comment) vuejs/core#4344 (comment)

fritx added a commit that referenced this issue Sep 2, 2022

switching to vite !! + umd support -- #137

99fd47b

vuetifyjs/vuetify#4068 (comment) vuejs/core#4344 (comment)

fritx added a commit that referenced this issue Sep 2, 2022

switching to vite !! + umd support -- #137

972130e

vuetifyjs/vuetify#4068 (comment) vuejs/core#4344 (comment)

fritx added fixed and removed in-progress labels Nov 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Do you have any plans to support vue3? #137

Do you have any plans to support vue3? #137

nsano-rururu commented Nov 28, 2021

fritx commented Dec 17, 2021

PaulSaveur commented May 20, 2022

Qiao0124 commented Jul 12, 2022

nsano-rururu commented Jul 23, 2022

Qiao0124 commented Aug 1, 2022

fritx commented Aug 3, 2022 •

edited

Loading

This comment was marked as off-topic.

fritx commented Aug 3, 2022 •

edited

Loading

nsano-rururu commented Aug 3, 2022 •

edited

Loading

fritx commented Aug 8, 2022 •

edited

Loading

Qiao0124 commented Aug 8, 2022

fritx commented Aug 9, 2022 •

edited

Loading

nsano-rururu commented Aug 9, 2022

fritx commented Aug 9, 2022

nsano-rururu commented Aug 9, 2022

fritx commented Aug 11, 2022 •

edited

Loading

fritx commented Sep 4, 2022

nsano-rururu commented Sep 4, 2022

nsano-rururu commented Sep 4, 2022

fritx commented Sep 4, 2022

nsano-rururu commented Sep 4, 2022

nsano-rururu commented Nov 4, 2022

junaidshad commented Mar 17, 2023

fritx commented Mar 20, 2023

fritx commented Mar 20, 2023 •

edited

Loading

junaidshad commented Mar 21, 2023

Do you have any plans to support vue3? #137

Do you have any plans to support vue3? #137

Comments

nsano-rururu commented Nov 28, 2021

fritx commented Dec 17, 2021

PaulSaveur commented May 20, 2022

Qiao0124 commented Jul 12, 2022

nsano-rururu commented Jul 23, 2022

Qiao0124 commented Aug 1, 2022

fritx commented Aug 3, 2022 • edited Loading

This comment was marked as off-topic.

fritx commented Aug 3, 2022 • edited Loading

nsano-rururu commented Aug 3, 2022 • edited Loading

fritx commented Aug 8, 2022 • edited Loading

Qiao0124 commented Aug 8, 2022

fritx commented Aug 9, 2022 • edited Loading

nsano-rururu commented Aug 9, 2022

fritx commented Aug 9, 2022

nsano-rururu commented Aug 9, 2022

fritx commented Aug 11, 2022 • edited Loading

fritx commented Sep 4, 2022

nsano-rururu commented Sep 4, 2022

nsano-rururu commented Sep 4, 2022

fritx commented Sep 4, 2022

nsano-rururu commented Sep 4, 2022

nsano-rururu commented Nov 4, 2022

junaidshad commented Mar 17, 2023

fritx commented Mar 20, 2023

fritx commented Mar 20, 2023 • edited Loading

junaidshad commented Mar 21, 2023

fritx commented Aug 3, 2022 •

edited

Loading

fritx commented Aug 3, 2022 •

edited

Loading

nsano-rururu commented Aug 3, 2022 •

edited

Loading

fritx commented Aug 8, 2022 •

edited

Loading

fritx commented Aug 9, 2022 •

edited

Loading

fritx commented Aug 11, 2022 •

edited

Loading

fritx commented Mar 20, 2023 •

edited

Loading