Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

close textarea panel if empty of text #59

Merged
merged 2 commits into from
Apr 27, 2018
Merged

close textarea panel if empty of text #59

merged 2 commits into from
Apr 27, 2018

Conversation

MaciejKus
Copy link

This removes the panel if there is no text for a textarea div.

As you can see in the example page at https://fritx.github.io/vue-at/#/en/vmodel if you have the panel open, then select all the text with the mouse and then hit delete the panel closes for the contenteditable example, but not the textarea example.

@fritx fritx merged commit da6f36d into fritx:dev Apr 27, 2018
@fritx
Copy link
Owner

fritx commented Apr 27, 2018

@MaciejKus cool ! Good catch!

Would be better we add a prop to config the tab behavior. At.js does it!

However, I've tried Wechat and QQ (which are popular IM apps in China), they don't, looks people in Asia dont have such convention?

@fritx fritx mentioned this pull request Apr 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants