small improvements

fritzmg · May 4, 2023 · 35a5794 · 35a5794
1 parent 298762c
commit 35a5794
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 4 deletions.
diff --git a/system/modules/sharebuttons/assets/scripts.js b/system/modules/sharebuttons/assets/scripts.js
@@ -2,6 +2,6 @@
 function shd() {};
 shd.open = function(href,width,height)
 {
-	window.open(href, '', 'width='+width+',height='+height+',modal=yes,left=100,top=50,location=no,menubar=no,resizable=yes,scrollbars=yes,status=no,toolbar=no');
+	window.open(href, '', 'width='+width+',height='+height+',location=no,menubar=no,resizable=yes,scrollbars=yes,status=no,toolbar=no');
 	return false;
 };
diff --git a/system/modules/sharebuttons/classes/ShareButtons.php b/system/modules/sharebuttons/classes/ShareButtons.php
@@ -120,7 +120,7 @@ public static function createShareButtons($networks, $theme = self::DEFAULT_THEM
         }
 
         // insert javascript
-        $GLOBALS['TL_JAVASCRIPT'][] = 'system/modules/sharebuttons/assets/scripts.js|static';
+        $GLOBALS['TL_JAVASCRIPT'][] = 'system/modules/sharebuttons/assets/scripts.js|async';
 
         // return parsed template
         return $objButtonsTemplate->parse();

diff --git a/system/modules/sharebuttons/templates/sharebuttons_default.html5 b/system/modules/sharebuttons/templates/sharebuttons_default.html5
@@ -8,7 +8,7 @@
       <?php elseif ($network == 'twitter'): ?>
         <li><a class="twitter" href="https://twitter.com/intent/tweet?url=<?= $this->url ?>&amp;text=<?= $this->title ?>" rel="noopener noreferrer nofollow" data-escargot-ignore title="<?= $this->lang['share_on_twitter'] ?>" onclick="return shd.open(this.href,500,260);">Twitter</a></li>
       <?php elseif ($network == 'linkedin'): ?>
-        <li><a class="linkedin" href="http://www.linkedin.com/shareArticle?mini=true&amp;url=<?= $this->url ?>&amp;title=<?= $this->title ?>" rel="noopener noreferrer nofollow" data-escargot-ignore title="<?= $this->lang['share_on_linkedin'] ?>" onclick="return shd.open(this.href,520,570);">LinkedIn</a></li>
+        <li><a class="linkedin" href="https://www.linkedin.com/shareArticle?mini=true&amp;url=<?= $this->url ?>&amp;title=<?= $this->title ?>" rel="noopener noreferrer nofollow" data-escargot-ignore title="<?= $this->lang['share_on_linkedin'] ?>" onclick="return shd.open(this.href,520,570);">LinkedIn</a></li>
       <?php elseif ($network == 'xing'): ?>
         <li><a class="xing" href="https://www.xing.com/social_plugins/share/new?sc_p=xing-share&amp;h=1&amp;url=<?= $this->url ?>" rel="noopener noreferrer nofollow" data-escargot-ignore title="<?= $this->lang['share_on_xing'] ?>" onclick="return shd.open(this.href,460,460);">Xing</a></li>
       <?php elseif ($network == 'mail'): ?>
@@ -31,3 +31,4 @@
   </ul>
 </div>
 <!-- indexer::continue -->
+
diff --git a/system/modules/sharebuttons/templates/sharebuttons_fontawesome.html5 b/system/modules/sharebuttons/templates/sharebuttons_fontawesome.html5
@@ -8,7 +8,7 @@
       <?php elseif ($network == 'twitter'): ?>
         <li><a class="twitter fa fa-twitter" href="https://twitter.com/intent/tweet?url=<?= $this->url ?>&amp;text=<?= $this->title ?>" rel="noopener noreferrer nofollow" data-escargot-ignore title="<?= $this->lang['share_on_twitter'] ?>" onclick="return shd.open(this.href,500,260);"></a></li>
       <?php elseif ($network == 'linkedin'): ?>
-        <li><a class="linkedin fa fa-linkedin" href="http://www.linkedin.com/shareArticle?mini=true&amp;url=<?= $this->url ?>&amp;title=<?= $this->title ?>" rel="noopener noreferrer nofollow" data-escargot-ignore title="<?= $this->lang['share_on_linkedin'] ?>" onclick="return shd.open(this.href,520,570);"></a></li>
+        <li><a class="linkedin fa fa-linkedin" href="https://www.linkedin.com/shareArticle?mini=true&amp;url=<?= $this->url ?>&amp;title=<?= $this->title ?>" rel="noopener noreferrer nofollow" data-escargot-ignore title="<?= $this->lang['share_on_linkedin'] ?>" onclick="return shd.open(this.href,520,570);"></a></li>
       <?php elseif ($network == 'xing'): ?>
         <li><a class="xing fa fa-xing" href="https://www.xing.com/social_plugins/share/new?sc_p=xing-share&amp;h=1&amp;url=<?= $this->url ?>" rel="noopener noreferrer nofollow" data-escargot-ignore title="<?= $this->lang['share_on_xing'] ?>" onclick="return shd.open(this.href,460,460);"></a></li>
       <?php elseif ($network == 'mail'): ?>