Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provided Docker image #2

Closed
wants to merge 1 commit into from
Closed

Provided Docker image #2

wants to merge 1 commit into from

Conversation

AKuHAK
Copy link
Contributor

@AKuHAK AKuHAK commented Apr 15, 2022

  • image hosted in Github Container
  • contains several layers

frno7
frno7 reviewed Apr 15, 2022
View reviewed changes
Copy link
Owner

@frno7 frno7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your commit author is AKuHAK <621640+AKuHAK@users.noreply.github.com>. Would you like to use your real name? I don’t think it’s particularly important here, but be aware that Linux kernel maintainers etc. only accept real names and won’t allow pseudonyms or anonymous contributions.

Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
.github/workflows/docker-publish.yml Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
@AKuHAK
Copy link
Contributor Author

AKuHAK commented Apr 15, 2022

Would you like to use your real name?

Oh, no, I plan to stick to AKuHAK. Btw this is the reason why I dont contribute in Linux repo :D I prepare some SCMD commands, but didnt publish them.

As about this particular repo is more like technical repo, I dont think that any parts of it will be merged in Linux repoes.

If that is a problem, use squash and merge option when merging the pr, then you will be an author and I will be co-author. I am fine with that.

@AKuHAK AKuHAK marked this pull request as draft April 16, 2022 15:09
@AKuHAK AKuHAK marked this pull request as ready for review April 16, 2022 16:32
@AKuHAK
Copy link
Contributor Author

AKuHAK commented Apr 16, 2022

It is ready for merging

@frno7
Copy link
Owner

frno7 commented Apr 17, 2022

Merged in commit 17bb9c5. Thank you for your contributions, @AKuHAK and @TobiX!

@AKuHAK AKuHAK closed this Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frno7 frno7 frno7 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AKuHAK @frno7