Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we’d have a dependency on @TobiX repo, then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is why I didnt made this pr earlier, caus eit is based on 3rd party docker container that can be removed in any moment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As about describing in Readme where files can be found, @frno7 do you mean just point to the the github official documentation? This is GitHub basic features I dont think that such features should be covered by repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AKuHAK, a couple of sentences about why and where (a URL) one might find the produced IRX files would be good, in the
README.md
especially. Maybe we ought to have a build pass/fail badge there too? :-)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AKuHAK, are you proposing frno7/linux#69 as a replacement for this pull request?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a replacement but more an addition. CI (Continuous Integration) is meant to be involved in each repository as a part of repository's internal check and as an easy way for generating precompiled binaries. This PR can be revisited when the necessary preparations will be made (as described in that PR).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@frno7 frno7/linux#69 is only the next step after you create one more repository for holding the main Docker image