You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Just a few things that could be changed once we can support Ember 2.5+. Maybe we could follow Ember's versions with support.?. (eg; Addon version 2.5.x requires Ember.js 2.5.x)
Replace Object.assign() with Ember.assign() (added in Ember 2.5) and remove the Babel polyfil requirement
@Panman8201 Wait a bit before using Ember.assign. I raised a question of why adding another Ember.keys functionality just to deprecate it in not a long time. It's going to be discussed once more.
Just hold on a little bit until it's in stable.
@cibernox While I agree that Babel really has taken the place for needing to add polyfills directly to Ember, it would be nice not needing to force users to include the Babel polyfill. Do you have a link to the discussion?
In order to move away from the Babel polyfill requirement, I've added an if statement to look for the new Ember.assign() polyfill or else fall-back to an Ember.merge() way of filling the need.
Just a few things that could be changed once we can support Ember 2.5+. Maybe we could follow Ember's versions with support.?. (eg; Addon version 2.5.x requires Ember.js 2.5.x)
Object.assign()
withEmber.assign()
(added in Ember 2.5) and remove the Babel polyfil requirementoptions
anddefaultOptions
properties, will work properly with the release of Ember 2.4.2The text was updated successfully, but these errors were encountered: