Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x ToDo List #1

Closed
2 of 3 tasks
Panman82 opened this issue Mar 7, 2016 · 3 comments
Closed
2 of 3 tasks

2.x ToDo List #1

Panman82 opened this issue Mar 7, 2016 · 3 comments

Comments

@Panman82
Copy link
Contributor

Panman82 commented Mar 7, 2016

Just a few things that could be changed once we can support Ember 2.5+. Maybe we could follow Ember's versions with support.?. (eg; Addon version 2.5.x requires Ember.js 2.5.x)

@cibernox
Copy link

cibernox commented Mar 7, 2016

@Panman8201 Wait a bit before using Ember.assign. I raised a question of why adding another Ember.keys functionality just to deprecate it in not a long time. It's going to be discussed once more.
Just hold on a little bit until it's in stable.

@Panman82
Copy link
Contributor Author

Panman82 commented Mar 8, 2016

@cibernox While I agree that Babel really has taken the place for needing to add polyfills directly to Ember, it would be nice not needing to force users to include the Babel polyfill. Do you have a link to the discussion?

@Panman82
Copy link
Contributor Author

In order to move away from the Babel polyfill requirement, I've added an if statement to look for the new Ember.assign() polyfill or else fall-back to an Ember.merge() way of filling the need.

@Panman82 Panman82 changed the title 2.5 ToDo List 2.x ToDo List Mar 10, 2016
@Panman82 Panman82 closed this as completed Nov 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants