[BUGFIX release] Fix mergedProperties at create time modifying proto #13031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @krisselden |
|
LGTM, chatted with @krisselden and he was 👍 also. I think this needs to go back into release (due to LTS), @Panman8201 can you use |
When `mergedProperties` are passed into an object at `.create()` time, the objects prototype is inadvertently modified, which is then reflected on all instances of the object. Simply passing in a new object during `assign()` resolves this problem (per krisselden). Also added a test for this use case, where `objA` results in 3 when the proto is modified. Fixes #11714
Panman82
changed the title
|
@rwjblue Done |
|
Thank you! |
rwjblue
added a commit
that referenced
this pull request
Mar 2, 2016
…-proto [BUGFIX release] Fix mergedProperties at create time modifying proto
This was referenced Mar 7, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
mergedPropertiesare passed into an object at.create()time, the objects prototype is inadvertently modified, which is then reflected on all instances of the object. Simply passing in a newobject during
assign()resolves this problem (per krisselden). Also added a test for this use case, whereobjAresults in 3 when the proto is modified. Fixes #11714