Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Foundry V12. #119

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Support for Foundry V12. #119

merged 2 commits into from
Jul 9, 2024

Conversation

alessiocali
Copy link
Contributor

I spent considerable time trying to figure out the project structure, I'm not a web dev expert but this should make the plugin compatible with V12 as far as I could see. The breaking changes were:

  • getAudioContext was changed into getAnalyzerContext
  • Some core labels for the ambient sound panel changed identifiers
  • The AmbientSound window/application was completely revamped, I did some touch-ups to support the new structure including in the Svelte components. Not as pretty as Foundry's original but it will suffice for now.

Closes #118

@Morfedel
Copy link

Morfedel commented Jul 9, 2024

I spent considerable time trying to figure out the project structure, I'm not a web dev expert but this should make the plugin compatible with V12 as far as I could see. The breaking changes were:

  • getAudioContext was changed into getAnalyzerContext
  • Some core labels for the ambient sound panel changed identifiers
  • The AmbientSound window/application was completely revamped, I did some touch-ups to support the new structure including in the Svelte components. Not as pretty as Foundry's original but it will suffice for now.

Closes #118

So, I'm ignorant on how github works, especially in conjunction with Foundry. How do you integrate these changes if they cant be auto updated in Foundry?

@ChunkLightTuna
Copy link

I spent considerable time trying to figure out the project structure, I'm not a web dev expert but this should make the plugin compatible with V12 as far as I could see. The breaking changes were:

  • getAudioContext was changed into getAnalyzerContext
  • Some core labels for the ambient sound panel changed identifiers
  • The AmbientSound window/application was completely revamped, I did some touch-ups to support the new structure including in the Svelte components. Not as pretty as Foundry's original but it will suffice for now.

Closes #118

So, I'm ignorant on how github works, especially in conjunction with Foundry. How do you integrate these changes if they cant be auto updated in Foundry?

something like

 git clone git@github.com:alessiocali/fvtt-syrin-control.git
 cd fvtt-syrin-control
 npm install
 npm run build
 cp -R dist <YOUR DATA DIR>/modules/fvtt-syrin-control

@alessiocali
Copy link
Contributor Author

I spent considerable time trying to figure out the project structure, I'm not a web dev expert but this should make the plugin compatible with V12 as far as I could see. The breaking changes were:

  • getAudioContext was changed into getAnalyzerContext
  • Some core labels for the ambient sound panel changed identifiers
  • The AmbientSound window/application was completely revamped, I did some touch-ups to support the new structure including in the Svelte components. Not as pretty as Foundry's original but it will suffice for now.

Closes #118

So, I'm ignorant on how github works, especially in conjunction with Foundry. How do you integrate these changes if they cant be auto updated in Foundry?

Until the maintainer approves the pull requests and publishes an updated version, unfortunately the only option is what @ChunkLightTuna mentioned - that is clone my fork, build it locally and patch your foundry data manually.

@todimusprime
Copy link

Just as an FYI - (after stumbling through trying to figure out what i actually needed to install and build all this) I have you fix installed and it appears to be working perfectly for me.

@frondeus
Copy link
Owner

frondeus commented Jul 9, 2024

Okay, as soon as the CI passes I will merge it and release new version

@alessiocali
Copy link
Contributor Author

Mh. Something on jest, possibly due to the changes I had to apply on the passed jquery token from Foundry. I'll have a look

@alessiocali
Copy link
Contributor Author

@frondeus The failure was indeed due to how I changed the AmbientSound component, it introduced a regression with respect to the V11 version. I fixed the regression but that still leaves the V12 version uncovered - I would need to change the fixture for that. If you don't mind I'd leave that for whoever takes the maintenance, this was more like a hotfix to not leave the community (...and myself tbqf :D ) without a V12 version.

@frondeus
Copy link
Owner

frondeus commented Jul 9, 2024

Yeah ok, merging :)

@frondeus frondeus merged commit ef40685 into frondeus:next Jul 9, 2024
3 of 4 checks passed
@frondeus
Copy link
Owner

frondeus commented Jul 9, 2024

I didnt test it, but i trust the community. New version has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support FoundryVTT v12
5 participants