Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add ability to publish to npm #6

Merged
merged 3 commits into from
May 3, 2022

Conversation

mwoodhousemckenzie
Copy link
Collaborator

@mwoodhousemckenzie mwoodhousemckenzie commented Apr 28, 2022

Description

This adds ability to publish this package to NPM. I had to update the package name and also moved the publishing of storybook to only when we release a new version.

Also I changed the version to 0.0.1 so when we publish our first component it will start the publishing at 0.1.0

Already added the npm token to secrets.

@xdmnl
Copy link
Member

xdmnl commented Apr 28, 2022

Do we want to go with GitHub action over Circle CI for build & release?

@mwoodhousemckenzie
Copy link
Collaborator Author

Do we want to go with GitHub action over Circle CI for build & release?

For the release-please stuff it has a simple github action wrapper and if we keep everything in Github, once we make this repo publish we don't have to worry as much about CircleCI stuff since that would be locked behind being part of our org there AFAIK. But I am open to changing things.

@xdmnl
Copy link
Member

xdmnl commented Apr 28, 2022

Sounds good. We have a lot of resources in Circle CI and less with GitHub Actions so we will keep an eye on how it performs and will revisit if needed.

.github/workflows/build-and-publish.yml Outdated Show resolved Hide resolved
.github/workflows/build-and-publish.yml Outdated Show resolved Hide resolved
.github/workflows/build-and-publish.yml Outdated Show resolved Hide resolved
.github/workflows/build-and-publish.yml Outdated Show resolved Hide resolved
.github/workflows/lint.yml Show resolved Hide resolved
@mwoodhousemckenzie mwoodhousemckenzie merged commit 8477c2d into main May 3, 2022
@mwoodhousemckenzie mwoodhousemckenzie deleted the PB-34794/add-publishing branch May 3, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants