Skip to content

Move to a smaller list virtualization library #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wuweiweiwu opened this issue Nov 19, 2018 · 7 comments · May be fixed by #467
Open

Move to a smaller list virtualization library #425

wuweiweiwu opened this issue Nov 19, 2018 · 7 comments · May be fixed by #467

Comments

@wuweiweiwu
Copy link
Member

wuweiweiwu commented Nov 19, 2018

React window https://github.com/bvaughn/react-window is a rewrite of react-virtualized that exposes a simpler api and is also way faster.

Alternative is react-tiny-virtual-list which is around the same size

react-window

react-window should be a viable option for this and is only ~2.5kb if you just import list for what it's worth.

react-tiny-virtual-list

Tiny & dependency free – Only 3kb gzipped

@wuweiweiwu wuweiweiwu changed the title Move to react-window Move to a smaller list virtualization library Jan 19, 2019
@wuweiweiwu
Copy link
Member Author

cc: @clauderic

@bvaughn
Copy link

bvaughn commented Jan 19, 2019

FWIW, I just checked and adding FixedSizeList from react-window to a project adds +2.13 KB (according to create-react-app)

@wuweiweiwu
Copy link
Member Author

Will explore that as well! thanks!

@af
Copy link

af commented Jan 28, 2019

@wuweiweiwu What are your thoughts on react-sortable-tree backwards compatibility with this change? Among the things I noticed when looking at migrating to react-window:

  • RST uses AutoSizer, should we pull in the react-virtualized-auto-sizer to maintain this behavior (it's not included in react-window AFAIK)?
  • The reactVirtualizedListProps prop could stick around but the name might be a bit misleading.

I'm sure there are more changes that I haven't noticed yet. Is the goal for the external API to remain as stable as possible, or to fit the underlying windowing library best?

@wuweiweiwu
Copy link
Member Author

RST uses AutoSizer, should we pull in the react-virtualized-auto-sizer to maintain this behavior (it's not included in react-window AFAIK)?

yep thats the plan

The reactVirtualizedListProps prop could stick around but the name might be a bit misleading.

in the release well keep the same prop name but we can alias reactWindowListProps to be the same thing and make a breaking change in a later release

@wuweiweiwu wuweiweiwu linked a pull request Mar 21, 2019 that will close this issue
2 tasks
@timothyarmes
Copy link

Are there still plans to move to a smaller library?

@wuweiweiwu
Copy link
Member Author

wuweiweiwu commented Oct 30, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants