Skip to content

WIP: rtl support #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

wuweiweiwu
Copy link
Member

@wuweiweiwu wuweiweiwu commented Jun 4, 2018

closes: #209
closes: #325
closes: #253
closes: #311

@wuweiweiwu wuweiweiwu mentioned this pull request Jun 4, 2018
@lionben89 lionben89 deleted the rtl-support branch June 4, 2018 09:51
@lionben89
Copy link

Hi,

I pushed a new commit [https://github.com/lionben89/react-sortable-tree/commit/80e8d3bead5a74c52f9e45397dec6b11bca3f9b6], but I don't see it in the pull request.

I tested everything manually and it works, but I need to update the automatic tests. How do I do that?
What is that snapshot?

@wuweiweiwu
Copy link
Member Author

you deleted the original branch so it is not updating on this branch.

if you go to master...lionben89:feature-rtl-support you can create a pull request manually.

@wuweiweiwu wuweiweiwu mentioned this pull request Jun 4, 2018
2 tasks
@wuweiweiwu
Copy link
Member Author

I've created another one for you! to make sure the automatic tests pass use npm run test

@wuweiweiwu wuweiweiwu closed this Jun 4, 2018
@wuweiweiwu wuweiweiwu mentioned this pull request Jun 6, 2018
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rtl-support RTL drag and drop issue RTL support? Does the component support direction changing?
2 participants