Skip to content

fix: scroll to search focused tree item #756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 30, 2020
Merged

fix: scroll to search focused tree item #756

merged 2 commits into from
Jul 30, 2020

Conversation

AKhodykin
Copy link
Contributor

Scrolling to the focused tree item was not working properly, due to a bug in getDerivedStateFromProps method. The ignoreOneTreeUpdate flag is expected to be in newState.instanceProps, while static search method puts it in newState. So the flag is ignored before the next render.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 76.636% when pulling a9edd1a on AKhodykin:bugfix/ignoreOneTreeUpdate into 1c1ed8c on frontend-collective:master.

wuweiweiwu
wuweiweiwu approved these changes Jul 30, 2020
View reviewed changes
Copy link
Member

@wuweiweiwu wuweiweiwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@wuweiweiwu wuweiweiwu merged commit e528a4c into frontend-collective:master Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wuweiweiwu wuweiweiwu wuweiweiwu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AKhodykin @coveralls @wuweiweiwu