-
Notifications
You must be signed in to change notification settings - Fork 12
Make this plugin work more similar to gulp-svg-sprite #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thanks for the pull request, however maybe you could enter a slightly aggressive tile next time? I'd love to look through your changes but as you've changed the indenting to two spaces instead of four I'm having trouble seeing them. If you could resubmit using the existing indenting that would be great. |
|
understood, I will clean up the format later today for review. It was past midnight when I did the first PR, should have do it with a better timing :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be a sync call so the result can be pushed into stream before the callback is triggered.
136fe83 to
ea4d1cf
Compare
|
@iamdarrenhall I reverted back the code style manually (as much as I can). Please let me know if you see any issue. I'd recommend setting up a code style guide (or use one of the popular one out there), it was a bit hard to follow some of the spacing in the current version as it has more than one style from line to line. Just my 2 cents. |
|
@iamdarrenhall I saw your did some commits that fix some of the same issues I fixed here, have you considered merging this in any time soon? |
|
@blai I'll try and look at merging this week. Unfortunately I can only fix project related bugs at work, so that's why I've done a couple that you've already spotted. The rest I have to do in my free time, which I've not had much of lately! Thanks for contributing though :–) |
@iamdarrenhall Thanks for sharing this great plugin. I encountered a few bugs, and while trying to resolve them, I throw in a few enhancements too. Unfortunately, I have an auto code prettifier running and reformatted your source (hope you don't mind).
Here are the details of this change:
svgDestoption to allow configuration of the output .svg file name + path