Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor login logic in preperation for 2FA #241

Merged
merged 1 commit into from
May 5, 2020
Merged

Conversation

fronzbot
Copy link
Owner

@fronzbot fronzbot commented May 5, 2020

Description:

Moves login logic to separate module for easier maintenance in prep for 2FA support

Checklist:

  • Local tests with tox run successfully PR cannot be meged unless tests pass
  • Changes tested locally to ensure platform still works as intended
  • Tests added to verify new code works

@codecov
Copy link

codecov bot commented May 5, 2020

Codecov Report

Merging #241 into dev will decrease coverage by 1.65%.
The diff coverage is 86.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #241      +/-   ##
==========================================
- Coverage   82.78%   81.13%   -1.66%     
==========================================
  Files           7        8       +1     
  Lines         674      689      +15     
==========================================
+ Hits          558      559       +1     
- Misses        116      130      +14     
Flag Coverage Δ
#unittests 81.13% <86.74%> (-1.66%) ⬇️
Impacted Files Coverage Δ
blinkpy/api.py 68.23% <50.00%> (-8.60%) ⬇️
blinkpy/blinkpy.py 80.47% <76.92%> (-1.35%) ⬇️
blinkpy/login_handler.py 89.83% <89.83%> (ø)
blinkpy/helpers/constants.py 100.00% <100.00%> (ø)
blinkpy/helpers/util.py 88.67% <100.00%> (-6.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 853c596...f80a93f. Read the comment docs.

@fronzbot fronzbot merged commit 9bc20cc into dev May 5, 2020
@fronzbot fronzbot deleted the refactor-login-logic branch May 5, 2020 17:56
@fronzbot fronzbot mentioned this pull request May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant