Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2FA Support #242

Merged
merged 4 commits into from
May 6, 2020
Merged

Add 2FA Support #242

merged 4 commits into from
May 6, 2020

Conversation

fronzbot
Copy link
Owner

@fronzbot fronzbot commented May 5, 2020

Description:

  • Blink is disabling old endpoint as of 5/11
  • New endpoint appears to be used with 2FA

To-do:

  • Test 2FA endpoint. I can't find a way to set it up on my account, so I'm just guessing at how some things work.
  • Ensure token can be sent without command-line interaction (for Home-Assistant support)
  • Add tests for any new functions
  • Make sure re-auth logic doesn't cause unwanted behavior with 2FA

Related issue (if applicable): #210

Checklist:

  • Local tests with tox run successfully PR cannot be meged unless tests pass
  • Changes tested locally to ensure platform still works as intended
  • Tests added to verify new code works

@codecov
Copy link

codecov bot commented May 5, 2020

Codecov Report

Merging #242 into dev will increase coverage by 1.38%.
The diff coverage is 88.60%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #242      +/-   ##
==========================================
+ Coverage   81.13%   82.51%   +1.38%     
==========================================
  Files           8        8              
  Lines         689      755      +66     
==========================================
+ Hits          559      623      +64     
- Misses        130      132       +2     
Flag Coverage Δ
#unittests 82.51% <88.60%> (+1.38%) ⬆️
Impacted Files Coverage Δ
blinkpy/api.py 69.76% <0.00%> (+1.53%) ⬆️
blinkpy/helpers/constants.py 100.00% <ø> (ø)
blinkpy/blinkpy.py 82.29% <90.32%> (+1.81%) ⬆️
blinkpy/sync_module.py 76.47% <92.30%> (+2.07%) ⬆️
blinkpy/login_handler.py 91.11% <93.75%> (+1.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f80a93f...1e86e7e. Read the comment docs.

@fronzbot fronzbot merged commit 86aae07 into dev May 6, 2020
@fronzbot fronzbot deleted the add-2FA branch May 6, 2020 02:51
@fronzbot fronzbot mentioned this pull request May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant