Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get_liveview command to camera module #289

Merged
merged 1 commit into from
Jun 8, 2020
Merged

Add get_liveview command to camera module #289

merged 1 commit into from
Jun 8, 2020

Conversation

fronzbot
Copy link
Owner

@fronzbot fronzbot commented Jun 8, 2020

Description:

Adds liveview extraction for camera

Related issue (if applicable): fixes #167

Checklist:

  • Local tests with tox run successfully PR cannot be meged unless tests pass
  • Changes tested locally to ensure platform still works as intended
  • Tests added to verify new code works

@codecov
Copy link

codecov bot commented Jun 8, 2020

Codecov Report

Merging #289 into dev will decrease coverage by 0.17%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #289      +/-   ##
==========================================
- Coverage   81.73%   81.55%   -0.18%     
==========================================
  Files           8        8              
  Lines         805      808       +3     
==========================================
+ Hits          658      659       +1     
- Misses        147      149       +2     
Flag Coverage Δ
#unittests 81.55% <33.33%> (-0.18%) ⬇️
Impacted Files Coverage Δ
blinkpy/camera.py 81.51% <33.33%> (-1.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b029c32...fd2e4ed. Read the comment docs.

@fronzbot fronzbot merged commit 31de65f into dev Jun 8, 2020
@fronzbot fronzbot deleted the add-liveview branch June 8, 2020 17:20
@jwenz723
Copy link

Typically a blink camera is not actually streaming any video unless you go into the blink app and hit the button to activate the live stream. Does executing get_liveview() simulate the same behavior as clicking that button to activate the stream?

I've successfully invoked get_liveview() to generate an rtsps uri, but I have been unsuccessful in viewing the stream while using ffmpeg cli, vlc player, or home assistant (using the built in ffmpeg). Do you have any examples of how you are viewing the live stream?

@fronzbot
Copy link
Owner Author

All get_liveviee() does is call the API endpoint to retrieve a stream link. I have not tested viewing the stream yet, so don't have any working examples.

@fronzbot fronzbot mentioned this pull request Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Camera stream
2 participants