Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove host from auth header #331

Merged
merged 2 commits into from
Jul 11, 2020
Merged

Remove host from auth header #331

merged 2 commits into from
Jul 11, 2020

Conversation

fronzbot
Copy link
Owner

Description:

Removes host from auth header (separate from 0.15.1 bugfix due to refactored code)

Related issue (if applicable): fixes #329

Checklist:

  • Local tests with tox run successfully PR cannot be meged unless tests pass
  • Changes tested locally to ensure platform still works as intended
  • Tests added to verify new code works

@codecov
Copy link

codecov bot commented Jul 11, 2020

Codecov Report

Merging #331 into dev will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #331   +/-   ##
=======================================
  Coverage   82.90%   82.90%           
=======================================
  Files           8        8           
  Lines         936      936           
=======================================
  Hits          776      776           
  Misses        160      160           
Flag Coverage Δ
#unittests 82.90% <100.00%> (ø)
Impacted Files Coverage Δ
blinkpy/auth.py 95.10% <100.00%> (ø)
blinkpy/helpers/constants.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77959d6...322aae3. Read the comment docs.

@fronzbot fronzbot merged commit 1aaa5b6 into dev Jul 11, 2020
@fronzbot fronzbot deleted the remove-host branch July 11, 2020 15:24
@fronzbot fronzbot mentioned this pull request Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error requesting networks
1 participant