Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test to catch NoneType error on refresh, fixed offending code #401

Merged
merged 1 commit into from
Nov 23, 2020

Conversation

fronzbot
Copy link
Owner

Description:

Adds exception catch to prevent NoneType error on refresh, added test to check behavior as well

  • Unrelated: had to add two force methods to refresh for testing purposes. Should not change normal usage.

Related issue (if applicable): fixes #392

Checklist:

  • Local tests with tox run successfully PR cannot be meged unless tests pass
  • Changes tested locally to ensure platform still works as intended
  • Tests added to verify new code works

@codecov
Copy link

codecov bot commented Nov 23, 2020

Codecov Report

Merging #401 (92a2cc2) into dev (0842739) will increase coverage by 1.56%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #401      +/-   ##
==========================================
+ Coverage   84.32%   85.89%   +1.56%     
==========================================
  Files           8        8              
  Lines         957      957              
==========================================
+ Hits          807      822      +15     
+ Misses        150      135      -15     
Flag Coverage Δ
unittests 85.89% <83.33%> (+1.56%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
blinkpy/sync_module.py 91.83% <50.00%> (+5.10%) ⬆️
blinkpy/blinkpy.py 80.54% <100.00%> (+1.35%) ⬆️
blinkpy/api.py 65.59% <0.00%> (+2.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0842739...92a2cc2. Read the comment docs.

@fronzbot fronzbot merged commit ba3c2e3 into dev Nov 23, 2020
@fronzbot fronzbot deleted the fix-exception-on-refresh branch November 23, 2020 04:04
@fronzbot fronzbot mentioned this pull request Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception on blink.refresh
1 participant