Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Blink Mini arming control #546

Merged
merged 4 commits into from
Mar 5, 2022
Merged

Add Blink Mini arming control #546

merged 4 commits into from
Mar 5, 2022

Conversation

mstratford
Copy link
Contributor

Description:

Based on @macleajb's work in #366

Adds camera arming support to Blinkpy.

I'm not sure how well Blink Mini is covered in the test framework, but if it's needed for this, I can look into it.

Related issue (if applicable): fixes #366

Checklist:

  • Local tests with tox run successfully PR cannot be meged unless tests pass
  • Changes tested locally to ensure platform still works as intended
  • Tests added to verify new code works

@mstratford
Copy link
Contributor Author

Tested this on my local home assistant.

@codecov
Copy link

codecov bot commented Mar 5, 2022

Codecov Report

Merging #546 (bf45211) into dev (f755855) will decrease coverage by 0.15%.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #546      +/-   ##
==========================================
- Coverage   86.38%   86.23%   -0.16%     
==========================================
  Files           8        8              
  Lines        1058     1061       +3     
==========================================
+ Hits          914      915       +1     
- Misses        144      146       +2     
Flag Coverage Δ
unittests 86.23% <40.00%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
blinkpy/camera.py 84.40% <25.00%> (-0.84%) ⬇️
blinkpy/api.py 64.58% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f755855...bf45211. Read the comment docs.

@fronzbot
Copy link
Owner

fronzbot commented Mar 5, 2022

Looks good, thanks for the PR! Sorry it took so long to review 😬

@fronzbot fronzbot merged commit 577cb2e into fronzbot:dev Mar 5, 2022
@fronzbot fronzbot mentioned this pull request Mar 5, 2022
@swerb73
Copy link

swerb73 commented Mar 6, 2022

Any chance anyone tested this with the doorbell?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot arm/disarm Blink Mini Cameras
3 participants