Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new request url for camera config #65

Merged
merged 2 commits into from
May 21, 2018
Merged

Added new request url for camera config #65

merged 2 commits into from
May 21, 2018

Conversation

fronzbot
Copy link
Owner

@fronzbot fronzbot commented May 21, 2018

Description:

  • Adds support for battery voltage level
  • Added new camera properties (wifi_strength, motion_detected)
  • Store full camera config from request into dict

Related issue (if applicable): fixes #64

Checklist:

  • Local tests with tox run successfully PR cannot be meged unless tests pass
  • If user-facing functionality changed, README.rst updated
  • Tests added to verify new code works

- Adds support for battery voltage level
- Added new camera properties (wifi_strength, motion_detected)
- Store full camera config from request into dict
try:
cfg = self.blink._camera_config_request(self.id)
self.camera_config = cfg
except:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not use bare except'

self.header = None
self.image_link = None
self.arm_link = None
self.region_id = config['region_id']
self.battery_voltage = -180

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trailing whitespace

@fronzbot fronzbot merged commit 65dd547 into dev May 21, 2018
@fronzbot fronzbot deleted the battery-percent branch May 21, 2018 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report battery status as % rather than "OK"
2 participants