Add new keys for wifi, lfr, and battery #835
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The API has changed - appears the wifi_strength and battery_voltage keys have been removed and a new key:
signals:{'lfr': 5, 'wifi': 4, 'battery': 3}
has been added.If the new key (signals) exists, we populate the values using the sub keys, if not, fall back to previous key names.
Add "sync_signal_strength" to attributes.
I'm not sure if the original wifi_strength key was 0-5 or actual signal strength (I think was was signal strength).I suppose we need to change the HA side to not show dBm? Should we do a percentage (5/5 = 100%, 1/5 - 20%) or maybe do this on the HA side?
Related issue (if applicable): fixes #
home-assistant/core#106509
Checklist:
tox
run successfully PR cannot be meged unless tests pass