Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete header match #856

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Complete header match #856

merged 1 commit into from
Jan 9, 2024

Conversation

mkmer
Copy link
Contributor

@mkmer mkmer commented Jan 9, 2024

Description:

Add APP_BUILD to the headers addressing the "need update" bug.

Related issue (if applicable): fixes #855

Checklist:

  • Local tests with tox run successfully PR cannot be meged unless tests pass
  • Changes tested locally to ensure platform still works as intended
  • Tests added to verify new code works

@mkmer
Copy link
Contributor Author

mkmer commented Jan 9, 2024

I guess I did have time to figure it out :)

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b02f3f2) 99.86% compared to head (dc03f76) 99.86%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #856   +/-   ##
=======================================
  Coverage   99.86%   99.86%           
=======================================
  Files           8        8           
  Lines        1476     1477    +1     
=======================================
+ Hits         1474     1475    +1     
  Misses          2        2           
Flag Coverage Δ
unittests 99.86% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fronzbot fronzbot merged commit 7d0e1f6 into fronzbot:dev Jan 9, 2024
8 checks passed
@fronzbot
Copy link
Owner

fronzbot commented Jan 9, 2024

Need a 0.22.6 release or hold off for now?

@mkmer
Copy link
Contributor Author

mkmer commented Jan 9, 2024

I think we can hold off.
If they start "detecting" us this we may need a release. My goal was to make sure we match 100% and we didn't :(
Thanks

@mkmer mkmer deleted the fix_app_update branch January 9, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App update required....
2 participants