Merge pull request #33 from froozeify/sales-improvements

Sales improvements
froozeify · Aug 12, 2024 · 2be6687 · 2be6687
2 parents c15d845 + 2170c64
commit 2be6687
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/src/Entity/Sale.php b/src/Entity/Sale.php
@@ -10,6 +10,7 @@
 use ApiPlatform\Metadata\Delete;
 use ApiPlatform\Metadata\Get;
 use ApiPlatform\Metadata\GetCollection;
+use ApiPlatform\Metadata\Patch;
 use ApiPlatform\Metadata\Post;
 use App\Entity\Interface\TimestampEntityInterface;
 use App\Entity\Trait\TimestampTrait;
@@ -29,6 +30,9 @@
     new GetCollection(),
     new Get(),
     new Post(),
+    new Patch(
+      security: "is_granted('ROLE_ADMIN') || is_granted('SALE_UPDATE', object)",
+    ),
     new Delete(
       security: "is_granted('ROLE_ADMIN') || is_granted('SALE_DELETE', object)",
     ),
@@ -37,7 +41,7 @@
     'groups' => ['sale', 'sale-read', 'timestamp']
   ],
   denormalizationContext: [
-    'groups' => ['sale', 'sale-write']
+    'groups' => ['sale', 'sale-write', 'timestamp-write-create']
   ],
   order: ['createdAt' => 'DESC']
 )]

diff --git a/src/Entity/Trait/TimestampTrait.php b/src/Entity/Trait/TimestampTrait.php
@@ -8,11 +8,11 @@
 
 trait TimestampTrait {
   #[ORM\Column(type: Types::DATETIME_IMMUTABLE, nullable: true)]
-  #[Groups(['timestamp'])]
+  #[Groups(['timestamp', 'timestamp-write-create'])]
   private ?\DateTimeImmutable $createdAt = null;
 
   #[ORM\Column(type: Types::DATETIME_IMMUTABLE, nullable: true)]
-  #[Groups(['timestamp'])]
+  #[Groups(['timestamp', 'timestamp-write-update'])]
   private ?\DateTimeImmutable $updatedAt = null;
 
   public function getCreatedAt(): ?\DateTimeImmutable {

diff --git a/src/Security/Voter/SaleDeleteVoter.php → src/Security/Voter/SaleVoter.php b/src/Security/Voter/SaleDeleteVoter.php → src/Security/Voter/SaleVoter.php
@@ -10,7 +10,8 @@
 use Symfony\Component\Security\Core\Authorization\Voter\Voter;
 use Symfony\Component\Security\Core\User\UserInterface;
 
-class SaleDeleteVoter extends Voter {
+class SaleVoter extends Voter {
+  public const UPDATE = 'SALE_UPDATE';
   public const DELETE = 'SALE_DELETE';
 
   public function __construct(
@@ -19,7 +20,7 @@ public function __construct(
   }
 
   protected function supports(string $attribute, mixed $subject): bool {
-    return $attribute == self::DELETE && $subject instanceof Sale;
+    return $subject instanceof Sale && in_array($attribute, [self::UPDATE, self::DELETE]);
   }
 
   protected function voteOnAttribute(string $attribute, mixed $subject, TokenInterface $token): bool {