Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make importing member presences async #48

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Conversation

froozeify
Copy link
Owner

No description provided.

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 81.13208% with 10 lines in your changes missing coverage. Please review.

Project coverage is 74.01%. Comparing base (2f7a399) to head (184c6e7).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/Importer/ImportExternalPresence.php 33.33% 4 Missing ⚠️
src/Importer/ImportMemberPresence.php 33.33% 4 Missing ⚠️
src/Importer/AbstractCsvImporter.php 83.33% 1 Missing ⚠️
src/Service/AbstractCsvService.php 85.71% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #48      +/-   ##
============================================
+ Coverage     73.94%   74.01%   +0.07%     
- Complexity     1441     1457      +16     
============================================
  Files           154      157       +3     
  Lines          4302     4345      +43     
============================================
+ Hits           3181     3216      +35     
- Misses         1121     1129       +8     
Components Coverage Δ
Entity 82.19% <ø> (ø)
Controller 77.74% <100.00%> (-0.07%) ⬇️
Files with missing lines Coverage Δ
...pendent/Plugin/Presence/MemberPresencesFromCsv.php 87.50% <100.00%> (-1.39%) ⬇️
...r/Doctrine/TimestampEntityPrePersistSubscriber.php 100.00% <ø> (ø)
src/Message/MemberPresencesCsvMessage.php 100.00% <100.00%> (ø)
...essageHandler/MemberPresencesCsvMessageHandler.php 100.00% <100.00%> (ø)
src/Service/ImportItacCsvService.php 100.00% <ø> (+2.70%) ⬆️
src/Service/MemberPresenceService.php 94.59% <100.00%> (+2.92%) ⬆️
src/Importer/AbstractCsvImporter.php 68.02% <83.33%> (+1.36%) ⬆️
src/Service/AbstractCsvService.php 85.71% <85.71%> (ø)
src/Importer/ImportExternalPresence.php 88.88% <33.33%> (-6.95%) ⬇️
src/Importer/ImportMemberPresence.php 88.23% <33.33%> (-7.33%) ⬇️

@froozeify froozeify self-assigned this Feb 19, 2025
@froozeify froozeify merged commit f3af250 into main Feb 19, 2025
5 checks passed
@froozeify froozeify deleted the make-import-presence-async branch February 19, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant