Support added for negative starting or ending balance #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,2 +1,3 @@ | |||
| composer.lock | |||
| /.idea/ | |||
There was a problem hiding this comment.
I think all specific IDE stuff (like .idea directory created by JetBrains' IDE shouldnt be here...) You should move that over to your local global .gitignore file...
(see for example here http://stackoverflow.com/questions/6626136/best-practice-for-adding-gitignore-to-repo)
|
Cool! Looks good to me, although i'd like to see the gitignore change reverted since i dont believe that should be in the project itself, but in your local global gitignore |
This reverts commit abcfd28.
|
No problem :) Reverted that commit now |
|
LGTM 👍 |
fruitl00p
added a commit
that referenced
this pull request
Aug 25, 2015
Support added for negative starting or ending balance
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looked like the starting and ending balance were always assumed to be a positive.
This pr adds support for negative balances