Skip to content

facebook v2.1.3 #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Jan 30, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
c8c3e48
Update adding-typescript.md
gaearon Jan 3, 2019
dae67ff
Fix typo in CSS modules docs (#6067)
Jan 4, 2019
6a95aae
Prepare 2.1.3 release
ianschmitz Jan 4, 2019
0d0d034
Publish
ianschmitz Jan 4, 2019
73e3d0e
Update CHANGELOG.md
ianschmitz Jan 4, 2019
3e1dc99
Fix CI and upgrade dependencies (#6137)
Timer Jan 6, 2019
005ee5b
Bump eslint-plugin-react version and update webpack config (#6132)
ianschmitz Jan 6, 2019
773d103
Switch to eval-source-map (#5060)
jasonLaster Jan 7, 2019
ddf2941
Remove extra table cell (#6141)
yangshun Jan 7, 2019
caf0eff
update link for difference between proposal stages (#6149)
loveky Jan 8, 2019
6e261f8
Update react-dev-util globby dependency to v8.0.2 (#6162)
davidlukerice Jan 9, 2019
2741781
Add note for global install of CLI (#6157)
ianschmitz Jan 9, 2019
c8a540d
Add react/react-dom dependencies to relative-paths test fixture (#6165)
ianschmitz Jan 11, 2019
132ac35
Update local-test.sh to return test exit code (#6179)
dallonf Jan 11, 2019
8174eed
Upgrade @svgr/webpack to 4.1.0 (#5816)
alaycock Jan 12, 2019
47e9e2c
Move chalk dependency to react-dev-utils (#6150)
evaporei Jan 12, 2019
fd38277
Ignore node_modules in verifyNoTypeScript (#6022)
Jan 14, 2019
34e5029
Add empty mock for module (#5798)
dotansimha Jan 16, 2019
803946f
Changes to steps for publishing GitHub User Page (#6095)
Jan 17, 2019
ed5fb10
Update updating-to-new-releases.md with note about global installs (#…
carpben Jan 20, 2019
1c591cb
Update `serve` change listening port documentation (#6229)
lyzhovnik Jan 20, 2019
3efcdbf
Fix e2e:docker test failure (#6050)
jamesknelson Jan 22, 2019
91f54af
Update stale config to ignore additional labels
iansu Jan 25, 2019
714599d
Prevent cursor events on app-logo svg (#6276)
kostadriano Jan 25, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/stale.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,14 @@ daysUntilClose: 5

# Issues or Pull Requests with these labels will never be considered stale. Set to `[]` to disable
exemptLabels:
- "issue: proposal"
- "contributions: claimed"
- "contributions: up for grabs!"
- "good first issue"
- "issue: announcement"
- "issue: bug"
- "issue: proposal"
- "tag: bug fix"
- "tag: needs investigation"

# Set to true to ignore issues in a project (defaults to false)
exemptProjects: true
Expand Down
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ cache:
directories:
- .npm
before_install:
- curl -o- -L https://yarnpkg.com/install.sh | bash -s -- --nightly
- curl -o- -L https://yarnpkg.com/install.sh | bash -s
- export PATH="$HOME/.yarn/bin:$PATH"
install: true
script:
Expand Down
50 changes: 50 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,53 @@
## 2.1.3 (January 4, 2019)

v2.1.3 is a maintenance release to fix a [vulnerability in webpack-dev-server](https://www.npmjs.com/advisories/725).

#### :memo: Documentation

- Other
- [#6067](https://github.com/facebook/create-react-app/pull/6067) Correct an error for documentation. ([@hardo](https://github.com/hardo))
- [#6110](https://github.com/facebook/create-react-app/pull/6110) Replace deprecated VSCode launch.json variable. ([@raiskila](https://github.com/raiskila))
- [#5631](https://github.com/facebook/create-react-app/pull/5631) Generalize the adding bootstrap documentation. ([@jquense](https://github.com/jquense))
- [#6084](https://github.com/facebook/create-react-app/pull/6084) Remove outdated docs for setting up eslint in editor. ([@LukasWerfel](https://github.com/LukasWerfel))
- [#6061](https://github.com/facebook/create-react-app/pull/6061) Fix control comment of CSS Grid prefixing. ([@denexapp](https://github.com/denexapp))
- `react-scripts`
- [#6036](https://github.com/facebook/create-react-app/pull/6036) Fix comment typo. ([@shawtung](https://github.com/shawtung))

#### :house: Internal

- `create-react-app`, `react-error-overlay`
- [#6104](https://github.com/facebook/create-react-app/pull/6104) Typo fixes. ([@prashant-andani](https://github.com/prashant-andani))

#### :hammer: Underlying Tools

- `react-scripts`
- [#6064](https://github.com/facebook/create-react-app/pull/6064) Update webpack-dev-server 3.1.9 -> 3.1.14. ([@Friss](https://github.com/Friss))

#### Committers: 8

- Denis Mukhametov ([denexapp](https://github.com/denexapp))
- Hardo ([hardo](https://github.com/hardo))
- Janne Raiskila ([raiskila](https://github.com/raiskila))
- Jason Quense ([jquense](https://github.com/jquense))
- Lukas Werfel ([LukasWerfel](https://github.com/LukasWerfel))
- Prashant Andani ([prashant-andani](https://github.com/prashant-andani))
- Zachary Friss ([Friss](https://github.com/Friss))
- [shawtung](https://github.com/shawtung)

### Migrating from 2.1.2 to 2.1.3

Inside any created project that has not been ejected, run:

```bash
npm install --save --save-exact react-scripts@2.1.3
```

or

```
yarn add --exact react-scripts@2.1.3
```

## 2.1.2 (December 23, 2018)

v2.1.2 is a maintenance release including various bug fixes.
Expand Down
2 changes: 1 addition & 1 deletion appveyor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ platform:
install:
- ps: Install-Product node $env:nodejs_version $env:platform
- ps: |
(New-Object Net.WebClient).DownloadFile("https://nightly.yarnpkg.com/latest.msi", "$env:temp\yarn.msi")
(New-Object Net.WebClient).DownloadFile("https://yarnpkg.com/latest.msi", "$env:temp\yarn.msi")
cmd /c start /wait msiexec.exe /i $env:temp\yarn.msi /quiet /qn /norestart

build: off
Expand Down
2 changes: 1 addition & 1 deletion docusaurus/docs/adding-a-css-modules-stylesheet.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ No clashes from other `.error` class names

```html
<!-- This button has red background but not red text -->
<button class="Button_error_ax7yz"></div>
<button class="Button_error_ax7yz">Error Button</button>
```

**This is an optional feature.** Regular `<link>` stylesheets and CSS files are fully supported. CSS Modules are turned on for files ending with the `.module.css` extension.
16 changes: 10 additions & 6 deletions docusaurus/docs/adding-typescript.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,17 +10,21 @@ title: Adding TypeScript
To start a new Create React App project with [TypeScript](https://www.typescriptlang.org/), you can run:

```bash
$ npx create-react-app my-app --typescript
$ # or
$ yarn create react-app my-app --typescript
npx create-react-app my-app --typescript

# or

yarn create react-app my-app --typescript
```

To add [TypeScript](https://www.typescriptlang.org/) to a Create React App project, first install it:

```bash
$ npm install --save typescript @types/node @types/react @types/react-dom @types/jest
$ # or
$ yarn add typescript @types/node @types/react @types/react-dom @types/jest
npm install --save typescript @types/node @types/react @types/react-dom @types/jest

# or

yarn add typescript @types/node @types/react @types/react-dom @types/jest
```

Next, rename any file to be a TypeScript file (e.g. `src/index.js` to `src/index.tsx`) and **restart your development server**!
Expand Down
2 changes: 1 addition & 1 deletion docusaurus/docs/advanced-configuration.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,4 @@ You can adjust various development and production settings by setting environmen
| CHOKIDAR_USEPOLLING | ✅ Used | 🚫 Ignored | When set to `true`, the watcher runs in polling mode, as necessary inside a VM. Use this option if `npm start` isn't detecting changes. |
| GENERATE_SOURCEMAP | 🚫 Ignored | ✅ Used | When set to `false`, source maps are not generated for a production build. This solves OOM issues on some smaller machines. |
| NODE_PATH | ✅ Used | ✅ Used | Same as [`NODE_PATH` in Node.js](https://nodejs.org/api/modules.html#modules_loading_from_the_global_folders), but only relative folders are allowed. Can be handy for emulating a monorepo setup by setting `NODE_PATH=src`. |
| INLINE_RUNTIME_CHUNK | 🚫 Ignored | ✅ Used | By default, Create React App will embed the runtime script into `index.html` during the production build. When set to `false`, the script will not be embedded and will be imported as usual. This is normally required when dealing with CSP. | |
| INLINE_RUNTIME_CHUNK | 🚫 Ignored | ✅ Used | By default, Create React App will embed the runtime script into `index.html` during the production build. When set to `false`, the script will not be embedded and will be imported as usual. This is normally required when dealing with CSP. |
21 changes: 13 additions & 8 deletions docusaurus/docs/deployment.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,11 @@ npm install -g serve
serve -s build
```

The last command shown above will serve your static site on the port **5000**. Like many of [serve](https://github.com/zeit/serve)’s internal settings, the port can be adjusted using the `-p` or `--port` flags.
The last command shown above will serve your static site on the port **5000**. Like many of [serve](https://github.com/zeit/serve)’s internal settings, the port can be adjusted using the `-l` or `--listen` flags:

```sh
serve -s build -l 4000
```

Run this command to get a full list of the options available:

Expand Down Expand Up @@ -106,7 +110,8 @@ To override this, specify the `homepage` in your `package.json`, for example:
This will let Create React App correctly infer the root path to use in the generated HTML file.

**Note**: If you are using `react-router@^4`, you can root `<Link>`s using the `basename` prop on any `<Router>`.<br>
More information [here](https://reacttraining.com/react-router/web/api/BrowserRouter/basename-string).<br>
More information [here](https://reacttraining.com/react-router/web/api/BrowserRouter/basename-string).<br>

<br>
For example:

Expand Down Expand Up @@ -240,7 +245,8 @@ For more information see [Firebase Hosting](https://firebase.google.com/docs/hos

### Step 1: Add `homepage` to `package.json`

**The step below is important!**<br>
**The step below is important!**<br>

**If you skip it, your app will not deploy correctly.**

Open your `package.json` and add a `homepage` field for your project:
Expand Down Expand Up @@ -291,11 +297,10 @@ Add the following scripts in your `package.json`:

The `predeploy` script will run automatically before `deploy` is run.

If you are deploying to a GitHub user page instead of a project page you'll need to make two
additional modifications:
If you are deploying to a GitHub user page instead of a project page you'll need to make one
additional modification:

1. First, change your repository's source branch to be any branch other than **master**.
1. Additionally, tweak your `package.json` scripts to push deployments to **master**:
1. Tweak your `package.json` scripts to push deployments to **master**:

```diff
"scripts": {
Expand All @@ -312,7 +317,7 @@ Then run:
npm run deploy
```

### Step 4: Ensure your project’s settings use `gh-pages`
### Step 4: For a project page, ensure your project’s settings use `gh-pages`

Finally, make sure **GitHub Pages** option in your GitHub project settings is set to use the `gh-pages` branch:

Expand Down
2 changes: 2 additions & 0 deletions docusaurus/docs/getting-started.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ cd my-app
npm start
```

> If you've previously installed `create-react-app` globally via `npm install -g create-react-app`, we recommend you uninstall the package using `npm uninstall -g create-react-app` to ensure that `npx` always uses the latest version.

_([npx](https://medium.com/@maybekatz/introducing-npx-an-npm-package-runner-55f7d4bd282b) comes with npm 5.2+ and higher, see [instructions for older npm versions](https://gist.github.com/gaearon/4064d3c23a77c74a3614c498a8bb1c5f))_

Then open [http://localhost:3000/](http://localhost:3000/) to see your app.
Expand Down
2 changes: 1 addition & 1 deletion docusaurus/docs/supported-browsers-features.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ This project supports a superset of the latest JavaScript standard. In addition
- [Class Fields and Static Properties](https://github.com/tc39/proposal-class-public-fields) (part of stage 3 proposal).
- [JSX](https://facebook.github.io/react/docs/introducing-jsx.html), [Flow](./adding-flow) and [TypeScript](./adding-typescript).

Learn more about [different proposal stages](https://babeljs.io/docs/plugins/#presets-stage-x-experimental-presets-).
Learn more about [different proposal stages](https://tc39.github.io/process-document/).

While we recommend using experimental proposals with some caution, Facebook heavily uses these features in the product code, so we intend to provide [codemods](https://medium.com/@cpojer/effective-javascript-codemods-5a6686bb46fb) if any of these proposals change in the future.

Expand Down
5 changes: 3 additions & 2 deletions docusaurus/docs/updating-to-new-releases.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,10 @@ Create React App is divided into two packages:
- `create-react-app` is a global command-line utility that you use to create new projects.
- `react-scripts` is a development dependency in the generated projects (including this one).

You almost never need to update `create-react-app` itself: it delegates all the setup to `react-scripts`.
When you run `npx create-react-app my-app` it automatically installs the latest version of Create React App.
> If you've previously installed `create-react-app` globally via `npm install -g create-react-app`, please visit [Getting Started](getting-started.md) to learn about current installation steps.

When you run `create-react-app`, it always creates the project with the latest version of `react-scripts` so you’ll get all the new features and improvements in newly created apps automatically.
Create React App creates the project with the latest version of `react-scripts` so you’ll get all the new features and improvements in newly created apps automatically.

To update an existing project to a new version of `react-scripts`, [open the changelog](https://github.com/facebook/create-react-app/blob/master/CHANGELOG.md), find the version you’re currently on (check `package.json` in this folder if you’re not sure), and apply the migration instructions for the newer versions.

Expand Down
3 changes: 2 additions & 1 deletion lerna.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@
"tag: bug fix": ":bug: Bug Fix",
"tag: enhancement": ":nail_care: Enhancement",
"tag: documentation": ":memo: Documentation",
"tag: internal": ":house: Internal"
"tag: internal": ":house: Internal",
"tag: underlying tools": ":hammer: Underlying Tools"
},
"cacheDir": ".changelog"
}
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"compile:lockfile": "node tasks/compile-lockfile.js"
},
"devDependencies": {
"eslint": "5.6.0",
"eslint": "5.12.0",
"execa": "1.0.0",
"fs-extra": "^7.0.0",
"get-port": "^4.0.0",
Expand Down
13 changes: 6 additions & 7 deletions packages/babel-plugin-named-asset-import/index.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ pluginTester({
pluginOptions: {
loaderMap: {
svg: {
ReactComponent: '@svgr/webpack?-prettier,-svgo![path]',
ReactComponent: '@svgr/webpack?-svgo![path]',
},
},
},
Expand Down Expand Up @@ -36,15 +36,15 @@ pluginTester({
svgReactComponentNamedImport: {
code: 'import { ReactComponent as logo } from "logo.svg";',
output:
'import { ReactComponent as logo } from "@svgr/webpack?-prettier,-svgo!logo.svg";',
'import { ReactComponent as logo } from "@svgr/webpack?-svgo!logo.svg";',
},
svgMultipleImport: {
code:
'import logo, { logoUrl , ReactComponent as Logo } from "logo.svg";',
output:
'import logo from "logo.svg";\n' +
'import { logoUrl } from "logo.svg";\n' +
'import { ReactComponent as Logo } from "@svgr/webpack?-prettier,-svgo!logo.svg";',
'import { ReactComponent as Logo } from "@svgr/webpack?-svgo!logo.svg";',
},
defaultExport: {
code: 'export default logo;',
Expand Down Expand Up @@ -81,18 +81,17 @@ pluginTester({
svgReactComponentNamedExport: {
code: 'export { ReactComponent as Logo } from "logo.svg";',
output:
'export { ReactComponent as Logo } from "@svgr/webpack?-prettier,-svgo!logo.svg";',
'export { ReactComponent as Logo } from "@svgr/webpack?-svgo!logo.svg";',
},
svgReactComponentExport: {
code: 'export { ReactComponent } from "logo.svg";',
output:
'export { ReactComponent } from "@svgr/webpack?-prettier,-svgo!logo.svg";',
output: 'export { ReactComponent } from "@svgr/webpack?-svgo!logo.svg";',
},
svgMultipleExport: {
code: 'export { logoUrl , ReactComponent as Logo } from "logo.svg";',
output:
'export { logoUrl } from "logo.svg";\n' +
'export { ReactComponent as Logo } from "@svgr/webpack?-prettier,-svgo!logo.svg";',
'export { ReactComponent as Logo } from "@svgr/webpack?-svgo!logo.svg";',
},
},
});
32 changes: 16 additions & 16 deletions packages/babel-preset-react-app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,24 +17,24 @@
"test.js"
],
"dependencies": {
"@babel/core": "7.1.6",
"@babel/plugin-proposal-class-properties": "7.1.0",
"@babel/plugin-proposal-decorators": "7.1.6",
"@babel/plugin-proposal-object-rest-spread": "7.0.0",
"@babel/plugin-syntax-dynamic-import": "7.0.0",
"@babel/plugin-transform-classes": "7.1.0",
"@babel/plugin-transform-destructuring": "7.1.3",
"@babel/plugin-transform-flow-strip-types": "7.1.6",
"@babel/plugin-transform-react-constant-elements": "7.0.0",
"@babel/plugin-transform-react-display-name": "7.0.0",
"@babel/plugin-transform-runtime": "7.1.0",
"@babel/preset-env": "7.1.6",
"@babel/core": "7.2.2",
"@babel/plugin-proposal-class-properties": "7.2.3",
"@babel/plugin-proposal-decorators": "7.2.3",
"@babel/plugin-proposal-object-rest-spread": "7.2.0",
"@babel/plugin-syntax-dynamic-import": "7.2.0",
"@babel/plugin-transform-classes": "7.2.2",
"@babel/plugin-transform-destructuring": "7.2.0",
"@babel/plugin-transform-flow-strip-types": "7.2.3",
"@babel/plugin-transform-react-constant-elements": "7.2.0",
"@babel/plugin-transform-react-display-name": "7.2.0",
"@babel/plugin-transform-runtime": "7.2.0",
"@babel/preset-env": "7.2.3",
"@babel/preset-react": "7.0.0",
"@babel/preset-typescript": "7.1.0",
"@babel/runtime": "7.1.5",
"babel-loader": "8.0.4",
"@babel/runtime": "7.2.0",
"babel-loader": "8.0.5",
"babel-plugin-dynamic-import-node": "2.2.0",
"babel-plugin-macros": "2.4.2",
"babel-plugin-transform-react-remove-prop-types": "0.4.20"
"babel-plugin-macros": "2.4.4",
"babel-plugin-transform-react-remove-prop-types": "0.4.21"
}
}
2 changes: 1 addition & 1 deletion packages/create-react-app/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "create-react-app",
"version": "2.1.2",
"version": "2.1.3",
"keywords": [
"react"
],
Expand Down
Loading