Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ident from proxies #375

Draft
wants to merge 1 commit into
base: frontierMaster
Choose a base branch
from
Draft

Conversation

johndaley-me
Copy link

Identity team is trying to use dtmulator in our apps but since many of our apps have binding_sets such as recovery.identity, by default the requests for our pages are being proxied to the integration app because of the /ident/ proxy entry. Removing the ident proxy entry will resolve this issue.

There still are some usages of this for entering/existing helper mode. We could probably work with those teams to add a proxy entry for those limited cases.

Just brainstorming, here are some alternatives:

  • Remove the /ident proxy--search GitHub usage and notify those impacted so they can create a proxy rule
  • Provide/figure out a way to opt out of the /ident proxy that Identity team can use or Identity team can work around it with something like require('@fs/react-scripts/proxy/proxies').find(({ route }) => route === '/ident').route = '/ident-no-proxy' in their setupProxy file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant