Fix npm issue to have git always use https #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redbugz
requested review from
joeycozza,
a team and
matthewmatician
and removed request for
a team
|
Tested with frontierApp, normal build step 5 minutes, without this fix, aborted at 25 minutes, with this fix back to normal 5 minutes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent changes to npm and/or Github have caused npm 6 to take a very long time to resolve github dependencies, likely due to the git protocol being no longer supported by Github
npm/cli#4896
https://github.blog/2021-09-01-improving-git-protocol-security-github/
https://stackoverflow.com/questions/19317264/does-github-support-git-protocol-for-pull/69812472#69812472
This forces all git interactions to be over https instead of the git protocol