add osx to travis (on master branch) #308

enricosada · 2016-09-08T13:54:55Z

with mono latest, let's check if osx works

with new edits from maintainers feature of github, i think you @kurtschelfthout can push commit to this branch

enricosada · 2016-09-08T14:48:01Z

fail on osx, ok on linux

                Tool /Library/Frameworks/Mono.framework/Versions/4.4.2/lib/mono/4.5/mcs.exe execution started with arguments: /noconfig /debug:pdbonly /optimize+ /out:obj/Release/FsCheck.CSharpExamples.exe Program.cs Properties/AssemblyInfo.cs obj/Release/.NETFramework,Version=v4.5.AssemblyAttribute.cs /target:exe /define:TRACE /nostdlib /reference:/Library/Frameworks/Mono.framework/Versions/4.4.2/lib/mono/gac/FSharp.Core/4.3.1.0__b03f5f7f11d50a3a/FSharp.Core.dll /reference:/Library/Frameworks/Mono.framework/Versions/4.4.2/lib/mono/4.5-api/System.dll /reference:/Library/Frameworks/Mono.framework/Versions/4.4.2/lib/mono/4.5-api/System.Data.dll /reference:/Library/Frameworks/Mono.framework/Versions/4.4.2/lib/mono/4.5-api/System.Core.dll /reference:/Users/travis/build/fscheck/FsCheck/src/FsCheck/bin/Release//FsCheck.dll /reference:/Library/Frameworks/Mono.framework/Versions/4.4.2/lib/mono/4.5-api/mscorlib.dll /warn:4
Program.cs(143,27): error CS0305: Using the generic type `FsCheck.Gen<a>' requires `1' type argument(s)
                /Users/travis/build/fscheck/FsCheck/src/FsCheck/bin/Release//FsCheck.dll (Location of the symbol related to previous error)
Program.cs(143,31): error CS0117: `FsCheck.Gen<a>' does not contain a definition for `Choose'
                /Users/travis/build/fscheck/FsCheck/src/FsCheck/bin/Release//FsCheck.dll (Location of the symbol related to previous error)
Program.cs(146,30): error CS0305: Using the generic type `FsCheck.Gen<a>' requires `1' type argument(s)
                /Users/travis/build/fscheck/FsCheck/src/FsCheck/bin/Release//FsCheck.dll (Location of the symbol related to previous error)
Program.cs(146,34): error CS0117: `FsCheck.Gen<a>' does not contain a definition for `OneOf'
                /Users/travis/build/fscheck/FsCheck/src/FsCheck/bin/Release//FsCheck.dll (Location of the symbol related to previous error)
Program.cs(148,31): error CS0305: Using the generic type `FsCheck.Gen<a>' requires `1' type argument(s)
                /Users/travis/build/fscheck/FsCheck/src/FsCheck/bin/Release//FsCheck.dll (Location of the symbol related to previous error)
Program.cs(148,35): error CS0117: `FsCheck.Gen<a>' does not contain a definition for `Frequency'
                /Users/travis/build/fscheck/FsCheck/src/FsCheck/bin/Release//FsCheck.dll (Location of the symbol related to previous error)
Program.cs(165,33): error CS0305: Using the generic type `FsCheck.Gen<a>' requires `1' type argument(s)
                /Users/travis/build/fscheck/FsCheck/src/FsCheck/bin/Release//FsCheck.dll (Location of the symbol related to previous error)
Program.cs(165,37): error CS0117: `FsCheck.Gen<a>' does not contain a definition for `Choose'
                /Users/travis/build/fscheck/FsCheck/src/FsCheck/bin/Release//FsCheck.dll (Location of the symbol related to previous error)
Program.cs(200,20): error CS0305: Using the generic type `FsCheck.Gen<a>' requires `1' type argument(s)
                /Users/travis/build/fscheck/FsCheck/src/FsCheck/bin/Release//FsCheck.dll (Location of the symbol related to previous error)
Program.cs(200,24): error CS0117: `FsCheck.Gen<a>' does not contain a definition for `Sized'
                /Users/travis/build/fscheck/FsCheck/src/FsCheck/bin/Release//FsCheck.dll (Location of the symbol related to previous error)
Program.cs(208,28): error CS0305: Using the generic type `FsCheck.Gen<a>' requires `1' type argument(s)
                /Users/travis/build/fscheck/FsCheck/src/FsCheck/bin/Release//FsCheck.dll (Location of the symbol related to previous error)
Program.cs(208,32): error CS0117: `FsCheck.Gen<a>' does not contain a definition for `Sized'
                /Users/travis/build/fscheck/FsCheck/src/FsCheck/bin/Release//FsCheck.dll (Location of the symbol related to previous error)

baronfel · 2016-09-08T17:24:36Z

I can reproduce this failure on my local Mono install. I'm running mono 4.4.2 stable, installed from Homebrew.

enricosada · 2016-09-08T17:28:26Z

really thx for help @baronfel

enricosada · 2016-09-08T18:00:53Z

The dll built by @baronfel on osx

FsCheck.zip

enricosada · 2016-09-08T18:02:27Z

There is no Gen class, only Gen<a>, that's explain the error

osx:

windows:

baronfel · 2016-09-08T18:08:38Z

Well now I've learned about Xamarin Studio's Assembly viewer. I definitely see the same thing.

enricosada · 2016-09-08T18:10:54Z

so GenModule instead of Gen

kurtschelfthout · 2016-09-08T20:13:21Z

src/FsCheck/Gen.fs

@@ -181,7 +181,7 @@ module Gen =
        | :? array<_> as arr ->
            elementsArr arr
        | _ ->
-            choose (0, (Seq.length xs)-1) |> map (flip Seq.nth xs)
+            choose (0, (Seq.length xs)-1) |> map (flip Seq.item xs)


As you've noticed, this fails because master is still on an older version of FSharp.Core. :)

#ifdef all the things! or not? i dont like warnings

btw i added this change because @baronfel tried to compile ootb with xamarin studio but failed (warning as error?), and the real compiler error of this issue was after these two warnings

That means you're compiling against a later version of FSharp.Core. FsCheck on master is compiled against 4.3.1.0 - this was not obsoleted in that version. So there is no reason for the ifdef. FsCheck project indeed has warnings as errors turned on.

kurtschelfthout · 2016-09-08T20:15:12Z

That must be an F# compiler bug I think that somehow manifests only when you build on OSX. There is no reason why the Gen module should have Module appended to it (and indeed, this does not happen if you build .NET on Windows, or mono on Linux...).

enricosada · 2016-09-08T20:17:20Z

Probably dotnet/fsharp#1319 and a different version of f# compiler

kurtschelfthout · 2016-09-08T20:37:53Z

Thanks @enricosada - I've added some comments to the RFC. I don't particularly agree with this new behavior of the compiler...and I can't seem to turn if off either. So kind of stuck on this.

enricosada · 2016-09-09T08:17:51Z

RFC or not, i think next questions are:

a workaround? [<CompiledName>] or something else?
why osx has this? it should not, it's using the same mono version of ubuntu.

/cc @dsyme

ploeh · 2016-09-09T08:28:34Z

using the same mono version of ubuntu

Not that I'd claim to be an expert at all, but I thought MacOS was based on Unix (i.e. not Linux, so also not Ubuntu)...

enricosada · 2016-09-09T08:35:03Z

@ploeh sry, bad phrase.

Using the same mono version number (4.2.2) in osx and ubuntu, why the fsc has that new RFC feature? or is a bug with osx only?
I tried also using mono 4.0.5 on osx (see travis logs ) and the error is the same. why?
is mono on osx installing HEAD fsc? dunno but is strange and should be investigated

kurtschelfthout · 2016-09-09T08:35:33Z

The correct fix here, imo, is to use the same version (or as close as possible) of the compiler on linux/osx as the one we're using on Windows.

Note that according to the RFC, even CompiledName doesn't work to override the name.

enricosada · 2016-09-09T08:36:55Z

@kurtschelfthout @ploeh we are getting this error on travis with mono version 4.0.5 (one year old), before the referenced pr (so maybe is not related but i think it is).

Mono JIT compiler version 4.0.5 ((detached/1d8d582 Tue Oct 20 15:15:33 EDT 2015)

that's strange..

we need a minimal repro of the issue and open a new issue in fsharp/fsharp repo

kurtschelfthout · 2016-09-09T08:39:11Z

@enricosada I mean version of fsc. Is that controllable?

kurtschelfthout · 2016-09-09T08:41:41Z

Yes, agree that's weird.

enricosada · 2016-09-09T08:44:08Z

i dont know an easy way, i dont have my mac near atm, and there is not sha commit in version.

Ok but for sure that's the last time, i am gonna add fsc /version and fsc /info, with info about git commit sha and build date. It's not the first time i have this pain

kurtschelfthout · 2016-09-09T20:12:51Z

@enricosada can you enable write access on this branch? see https://github.com/blog/2247-improving-collaboration-with-forks

GitHub seems to claim I don't have write access...

enricosada · 2016-09-09T20:20:30Z

Allow edits from maintainers.

Was already checked, dunno you get error in push?

kurtschelfthout · 2016-09-09T20:45:32Z

sorry, my mistake, git trouble :) worked now. I tried a few workarounds, we'll see...

enricosada · 2016-09-09T21:36:21Z

@kurtschelfthout remove some from build Matrix in travis.
Atm there are lots mono versions...

kurtschelfthout · 2016-09-09T21:51:22Z

This is so weird. The only build on linux that works, which claims to use F# 4.0 compiler and FSharp.Core 4.3.1.0 nonetheless gives a deprecation warning for Seq.nth. But for sure the FSharp.Core 4.3.1.0 on windows does not have that deprecation warning.

On OSX I have no idea what it's doing but it never works. And old mono on linux seems to kill the mono runtime when running paket.

What a mess!

kurtschelfthout · 2017-02-04T13:49:59Z

I give up on this :)

add osx to travis

5847dbd

enricosada mentioned this pull request Sep 8, 2016

Support .NET Core using .NET Core SDK #293

Closed

fix deprecation warning

28bc2d1

more mono on build matrix

de5218a

kurtschelfthout reviewed Sep 8, 2016
View reviewed changes

kurtschelfthout added 2 commits September 9, 2016 21:09

Fix build.

49bd7f2

Try adding various attributes to make GenModule go away.

b279e3c

kurtschelfthout added 3 commits November 27, 2016 12:10

Merge branch 'master' into add_osx_to_travis

ff86241

Merge branch 'master' into add_osx_to_travis

6eb6b03

Merge branch 'master' into add_osx_to_travis

f38f1ef

kurtschelfthout closed this Feb 4, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add osx to travis (on master branch) #308

add osx to travis (on master branch) #308

enricosada commented Sep 8, 2016

enricosada commented Sep 8, 2016

baronfel commented Sep 8, 2016

enricosada commented Sep 8, 2016

enricosada commented Sep 8, 2016

enricosada commented Sep 8, 2016

baronfel commented Sep 8, 2016

enricosada commented Sep 8, 2016

kurtschelfthout Sep 8, 2016

enricosada Sep 9, 2016

enricosada Sep 9, 2016

kurtschelfthout Sep 9, 2016

kurtschelfthout commented Sep 8, 2016

enricosada commented Sep 8, 2016

kurtschelfthout commented Sep 8, 2016 •

edited

Loading

enricosada commented Sep 9, 2016 •

edited

Loading

ploeh commented Sep 9, 2016

enricosada commented Sep 9, 2016

kurtschelfthout commented Sep 9, 2016

enricosada commented Sep 9, 2016 •

edited

Loading

kurtschelfthout commented Sep 9, 2016

kurtschelfthout commented Sep 9, 2016

enricosada commented Sep 9, 2016

kurtschelfthout commented Sep 9, 2016

enricosada commented Sep 9, 2016

kurtschelfthout commented Sep 9, 2016

enricosada commented Sep 9, 2016

kurtschelfthout commented Sep 9, 2016

kurtschelfthout commented Feb 4, 2017

add osx to travis (on master branch) #308

add osx to travis (on master branch) #308

Conversation

enricosada commented Sep 8, 2016

enricosada commented Sep 8, 2016

baronfel commented Sep 8, 2016

enricosada commented Sep 8, 2016

enricosada commented Sep 8, 2016

enricosada commented Sep 8, 2016

baronfel commented Sep 8, 2016

enricosada commented Sep 8, 2016

kurtschelfthout Sep 8, 2016

Choose a reason for hiding this comment

enricosada Sep 9, 2016

Choose a reason for hiding this comment

enricosada Sep 9, 2016

Choose a reason for hiding this comment

kurtschelfthout Sep 9, 2016

Choose a reason for hiding this comment

kurtschelfthout commented Sep 8, 2016

enricosada commented Sep 8, 2016

kurtschelfthout commented Sep 8, 2016 • edited Loading

enricosada commented Sep 9, 2016 • edited Loading

ploeh commented Sep 9, 2016

enricosada commented Sep 9, 2016

kurtschelfthout commented Sep 9, 2016

enricosada commented Sep 9, 2016 • edited Loading

kurtschelfthout commented Sep 9, 2016

kurtschelfthout commented Sep 9, 2016

enricosada commented Sep 9, 2016

kurtschelfthout commented Sep 9, 2016

enricosada commented Sep 9, 2016

kurtschelfthout commented Sep 9, 2016

enricosada commented Sep 9, 2016

kurtschelfthout commented Sep 9, 2016

kurtschelfthout commented Feb 4, 2017

kurtschelfthout commented Sep 8, 2016 •

edited

Loading

enricosada commented Sep 9, 2016 •

edited

Loading

enricosada commented Sep 9, 2016 •

edited

Loading