Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Paket and FAKE #662

Merged
merged 34 commits into from
Feb 25, 2024
Merged

Delete Paket and FAKE #662

merged 34 commits into from
Feb 25, 2024

Conversation

Smaug123
Copy link
Contributor

@Smaug123 Smaug123 commented Feb 24, 2024

This is now ready for review (as of e20ce41). There are some known quirks, which I'm listing in #663 ; this PR is massive, so I propose fixing them in follow-up PRs instead.

Nupkg dependencies are the same

dotnet fsi build.fsx -t NugetPack and then create NuGet.config:

<?xml version="1.0" encoding="utf-8"?>
<configuration>
  <packageSources>
    <add key="LocalSource" value="/Users/patrick/Documents/GitHub/FsCheck/bin" />
  </packageSources>
</configuration>

Verify deps in Rider:
Screenshot 2024-02-24 at 16 15 26

  • FsCheck
  • FsCheck.Xunit (new dependency on FSharp.Core >= 5.0.2 and I have no idea where it came from, but that would have been inherited from FsCheck anyway so I'm not too bothered about it)
  • FsCheck.NUnit

Tested on macOS

  • RunTests
  • Clean
  • CI
  • Build
  • Tests
  • Release - tested up to the point of performing the git push; GitHub release logic completely untested
  • Docs
  • WatchDocs
  • ReleaseDocs - tested up to the point of failing to git push due to my own restricted perms
  • NugetPack
  • NugetPush - tested to within the limits of my ability to publish to NuGet
  • BuildVersion - I don't know what this is here for but I do the same as what it used to do
  • AssemblyInfo

Tested on Windows

  • RunTests
  • Clean
  • CI
  • Build
  • Tests
  • Release
  • Docs
  • WatchDocs
  • ReleaseDocs
  • NugetPack
  • NugetPush - tested to within the limits of my ability to publish to NuGet
  • BuildVersion - I don't know what this is here for but I do the same as what it used to do
  • AssemblyInfo

@Smaug123
Copy link
Contributor Author

@kurtschelfthout I don't have perms to kill the existing runs, which are just spinning due to me falling victim to one of the classic .NET blunders (failing to call Process.BeginOutputReadLine). They're going to hang forever.

@Smaug123 Smaug123 changed the title Delete Paket Delete Paket and FAKE Feb 24, 2024
@Smaug123
Copy link
Contributor Author

Dear Lord I hate msbuild and NuGet. They're both so completely cursed.

build.fsx Show resolved Hide resolved
build.fsx Show resolved Hide resolved
build.fsx Show resolved Hide resolved
build.fsx Show resolved Hide resolved
build.fsx Show resolved Hide resolved
build.fsx Show resolved Hide resolved
build.fsx Show resolved Hide resolved
build.fsx Show resolved Hide resolved
build.fsx Show resolved Hide resolved
build.fsx Show resolved Hide resolved
@Smaug123
Copy link
Contributor Author

@kurtschelfthout Have at it; feel free to give it a go on a branch for releasing the docs!

@Smaug123
Copy link
Contributor Author

(Feel free to tell me to do anything better, by the way. After hours of fighting NuGet and the dotnet CLI, I stopped when I reached something that appeared to work; but tomorrow is a new day.)

@kurtschelfthout
Copy link
Member

This is awesome. I had to fix a few things when releasing the docs, but that's fine. I managed to release the docs which is great.

I'm going to test the nuget pack tomorrow, it's getting late here.

@kurtschelfthout
Copy link
Member

Pack looking great. I'm going to merge this, fix up on master what I've fixed up. Then I'll try an actual release of rc2, which will need a few additional fixes.

This is awesome. Much appreciated.

@kurtschelfthout kurtschelfthout merged commit 2e5fdba into fscheck:master Feb 25, 2024
1 check passed
@Smaug123 Smaug123 deleted the rem-paket branch February 25, 2024 10:23
@Smaug123
Copy link
Contributor Author

Cool - tag me if you need a hand with anything, I should be around for most of today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants